Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Envoy to 38c5c86 (Mar 25, 2024) #1110

Merged
merged 11 commits into from
Mar 28, 2024

Conversation

eric846
Copy link
Contributor

@eric846 eric846 commented Mar 25, 2024

  • .bazelrc updated from upstream
  • tools/code_format/config.yaml updated from upstream
  • In an incredibly confusing refactor:
    • Envoy's FaultFilterConfig started taking a CommonFactoryContext instead of a Runtime and TimeSource.
      • Updated HttpDynamicDelayDecoderFilterConfig to store a CommonFactoryContext& instead of a TimeSource&, so that it has a CommonFactoryContext& to use when constructing a FaultFilterConfig.
        • How to get a CommonFactoryContext when creating the HttpDynamicDelayDecoderFilterConfig? HttpDynamicDelayDecoderFilterConfigFactory has access to a Envoy::Server::Configuration::FactoryContext, which has a serverFactoryContext() method. ServerFactoryContext is a subclass of CommonFactoryContext.
    • Envoy has started calling serverFactoryContext() on the NighthawkServerInstance, which had a PANIC placeholder there. This was discovered in the integration tests.
      • Gave NighthawkServerInstance a reference to a NighthawkServerFactoryContext to return in serverFactoryContext(), replacing the PANIC placeholder.
      • In order to remove a circular dependency, took away NighthawkServerFactoryContext's reference to a NighthawkServerInstance, to which it delegated many calls. Now NighthawkServerFactoryContext stores its own references to the underlying objects formerly wrapped in the NighthawkServerInstance.
    • I originally assumed the above two things were related, but it appears that both arose here by coincidence.

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846 eric846 marked this pull request as ready for review March 26, 2024 04:22
@eric846 eric846 added the waiting-for-review A PR waiting for a review. label Mar 26, 2024
source/client/process_impl.cc Outdated Show resolved Hide resolved
source/client/process_impl.cc Outdated Show resolved Hide resolved
source/server/http_dynamic_delay_filter.h Outdated Show resolved Hide resolved
…NighthawkServerInstance

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
…g FaultFilterConfig, to avoid being unnecessarily specific

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
source/client/process_impl.cc Show resolved Hide resolved
source/client/process_impl.cc Outdated Show resolved Hide resolved
…sConfig() to PANIC

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@mum4k mum4k merged commit 7a3e602 into envoyproxy:main Mar 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-review A PR waiting for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants