Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Envoy to 66cc217 (Dec 20, 2024) #1267

Merged
merged 30 commits into from
Dec 27, 2024

Conversation

sebastianavila5
Copy link
Contributor

  • Updated .bazelrc, .bazelversion, and tools/code_format/config.yaml
  • no changes in ci/run_envoy_docker.sh. or tools/gen_compilation_database.py
  • Removed depracated bazel flag: experimental_local_memory_estimate

Signed-off-by: Sebastian Avila sebastianavila@google.com

Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
@sebastianavila5
Copy link
Contributor Author

sebastianavila5 commented Dec 24, 2024

  • test_output all does not provide any addtional info.
  • Attempted to Publish the test log mentioned in the output, it does not exist.
  • CI passes at head.
  • CI passes when keeping all envoy update changes (but keeping the bazel version at 6.5.0 vs 7.1.2).
  • benchmarks pass on local machine with bazel 7.1.2 (and 6.5.0)

Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
@sebastianavila5
Copy link
Contributor Author

sebastianavila5 commented Dec 26, 2024

Error identified:

_run_benchmark(inject_dynamic_envoy_http_proxy_fixture,
request_source_config=request_source_config)

/source/benchmarks/dynamic_test/test_cds_churn_with_traffic.py:136:


/source/benchmarks/dynamic_test/test_cds_churn_with_traffic.py:74: in _run_benchmark
args.append(_readRunfile(request_source_config))
/source/benchmarks/dynamic_test/test_cds_churn_with_traffic.py:84: in _readRunfile
with open(runfiles_instance.Rlocation(path)) as f:
../rules_python/python/runfiles/runfiles.py:186: in Rlocation
source_repo = self.CurrentRepository(frame=2)

ValueError: /source/benchmarks/dynamic_test/test_cds_churn_with_traffic.py does not lie under the runfiles root /build/.cache/bazel/_bazel_envoybuild/b570b5ccd0454dc9af9f65ab1833764d/sandbox/processwrapper-sandbox/4552/execroot/nighthawk/bazel-out/k8-opt/bin/benchmarks/test_dynamic_benchmarks.runfiles

Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
Signed-off-by: Sebastian Avila <sebastianavila@google.com>
@sebastianavila5 sebastianavila5 marked this pull request as ready for review December 26, 2024 07:52
@jiajunye
Copy link
Contributor

LGTM

@mum4k mum4k merged commit b32aebb into envoyproxy:main Dec 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants