Extract SignalHandler class for re-use #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation of sharing functionality for signal handling, extract what we have right now into SignalHandler. Status: draft For fixing envoyproxy#280 Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
|
@mum4k requesting early feedback on this; this extracts our signal handling code from
Would it make sense to shoot for landing this as-is? |
…ndler Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
…ndler Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
oschaaf
changed the title
This was referenced Jun 16, 2020
mum4k
requested changes
Jun 17, 2020
|
|
||
| namespace Nighthawk { | ||
|
|
||
| using SignalCallback = std::function<void()>; |
There was a problem hiding this comment.
Since this is part of the header - can we document it?
|
|
||
| using SignalCallback = std::function<void()>; | ||
|
|
||
| class SignalHandler final : public Envoy::Logger::Loggable<Envoy::Logger::Id::main> { |
There was a problem hiding this comment.
Let's also add documentation for the class including an example of usage.
|
|
||
| class SignalHandler final : public Envoy::Logger::Loggable<Envoy::Logger::Id::main> { | ||
| public: | ||
| SignalHandler(const SignalCallback& signal_callback); |
There was a problem hiding this comment.
Can we add documentation for the constructor?
| class SignalHandler final : public Envoy::Logger::Loggable<Envoy::Logger::Id::main> { | ||
| public: | ||
| SignalHandler(const SignalCallback& signal_callback); | ||
| SignalHandler(SignalHandler const&) = delete; |
There was a problem hiding this comment.
Can we add a single comment above these two to indicate the intention, something like:
// Not copyable or movable.
mum4k
added
waiting-for-changes
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
oschaaf
added
waiting-for-review
mum4k
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of sharing functionality for signal handling,
extract what we have right now into a
SignalHandlerclass.Preparation for #280
Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com