Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Envoy to 31128e7dc22355876020188bc8feb99304663041 #335

Merged
merged 10 commits into from
May 19, 2020
Merged

Update Envoy to 31128e7dc22355876020188bc8feb99304663041 #335

merged 10 commits into from
May 19, 2020

Conversation

oschaaf
Copy link
Member

@oschaaf oschaaf commented May 15, 2020 •
edited
Loading

  • As of this change we needed to reduce parallelism in CI
    to avoid OOM during coverage runs. This probably can
    be traced back to a new way of running coverage being
    used in Envoy, which trickled down to Nighthawk.
  • Removed our own io_bazel_rules_python as we can now
    piggy-back on Envoy for that.
  • Removes a file that accidentally crept in (lorem_ipsum.txt)

Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com

oschaaf added 6 commits May 15, 2020 08:33
@oschaaf
Update Envoy to 6e14acb2aae2a2f1826dc3e15470edc43a17a85d
3083730 
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf
Drop our own rules_python dependency as Envoy has it now.
e105379 
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf
Regen docs
73cf8e3 
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf
Remove accidental lorem_ipsum.txt
280a4af 
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf
Fix CI coverage runs. Move to bazel 3.1.0.
301e2c4 
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf
sync tools/shell_utils.sh
8f0fd30 
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf oschaaf added P1 waiting-for-review A PR waiting for a review. labels May 15, 2020
@oschaaf oschaaf marked this pull request as ready for review May 15, 2020 08:27
@oschaaf
coverage: lower local_ram_resources
08c9786 
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf oschaaf removed the waiting-for-review A PR waiting for a review. label May 15, 2020
@oschaaf
Copy link
Member Author

oschaaf commented May 15, 2020

The updated coverage seems to be a lot more memory hungry. I need to figure out why that is
and how to constrain it. The --local_ram_resources we had in place for running in CircleCI clearly
doesn't cut it.

oschaaf added 3 commits May 15, 2020 22:30
@oschaaf
CI/coverage: reduce parallelism, avoid OOM
b095905 
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf
CI/coverage: one more try
a7bd43c 
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf
Updat envoy to 31128e7dc22355876020188bc8feb99304663041
ecc7369 
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf oschaaf changed the title Update Envoy to 6e14acb2aae2a2f1826dc3e15470edc43a17a85d Update Envoy to 31128e7dc22355876020188bc8feb99304663041 May 17, 2020
@oschaaf oschaaf added the waiting-for-review A PR waiting for a review. label May 17, 2020
@oschaaf
Copy link
Member Author

oschaaf commented May 17, 2020

Optimistically marked this as ready for review.
I just updated this to the latest Envoy revision, which didn't need any
further changes. This also triggers another CI coverage run, which should not run into OOM
now that we have the parallelism tuned for it.

@mum4k mum4k merged commit db22145 into envoyproxy:master May 19, 2020
@oschaaf oschaaf mentioned this pull request Jun 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mum4k mum4k mum4k approved these changes

Assignees
No one assigned
Labels
P1 waiting-for-review A PR waiting for a review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oschaaf @mum4k