Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Test that we can produce artifacts with gcc #397

Merged
merged 14 commits into from
Jul 7, 2020

Conversation

oschaaf
Copy link
Member

@oschaaf oschaaf commented Jul 3, 2020

  • First iteration on testing gcc support in CI. This restricts the
    task to just building Nighthawk, and not testing it yet, as that
    needs a change in Envoy to go in first.
  • Small cleanup, and a bugfix for those who use the script to run
    locally, which would be detected as running in CircleCI.

Related issue: #382
(needs a follow up to close, left in as a code-level todo).

Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com


oschaaf added 8 commits July 2, 2020 00:14
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
- First iteration on testing gcc support in CI. This restricts the
task to just building Nighthawk, and not testing it yet, as that
needs a change in Envoy to go in first.
- Small cleanup, and a bugfix for those who use the script to run
locally, which would be detected as running in CircleCI.

- [ ] Prerequisite: envoyproxy#394

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf oschaaf added blocked A PR that is blocked by prerequisites. waiting-for-review A PR waiting for a review. labels Jul 3, 2020
@oschaaf
Copy link
Member Author

oschaaf commented Jul 3, 2020

I plan to restart the CI tasks in here to get a sense of stability, as there are changes in here that impact memory requirements.

oschaaf added 4 commits July 4, 2020 00:47
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf
Copy link
Member Author

oschaaf commented Jul 4, 2020

It looks like that when building the asan task with 3 concurrent jobs we get “Too long with no output (exceeded 10m0s): context deadline exceeded”fairly structurally instead of it being oom killed occasionally :( the link steps are very memory hungry, maybe we need to lower parallelism further. It might then also be worth looking into a way to wrap ‘ld’ to serialize just the link calls and have the compile steps run at higher concurrency, as that may save some time. That’s quite hacky though. Maybe there’s also a larger build VM available that we can use for asan. Memory seems very tight for asan; it may take a long time otherwise (approx 1.5-2hours).

force push to fix DCO

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf oschaaf force-pushed the oschaaf-gcc-ci-task branch from 665b302 to cd20455 Compare July 4, 2020 22:12
@oschaaf oschaaf removed the blocked A PR that is blocked by prerequisites. label Jul 7, 2020
Copy link
Collaborator

@mum4k mum4k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this coverage.

@mum4k mum4k merged commit 06a6a02 into envoyproxy:master Jul 7, 2020
wjuan-AFK pushed a commit to wjuan-AFK/nighthawk that referenced this pull request Jul 14, 2020
- First iteration on testing gcc support in CI. This restricts the
task to just building Nighthawk, and not testing it yet, as that
needs a change in Envoy to go in first.
- Small cleanup, and a bugfix for those who use the script to run
locally, which would be detected as running in CircleCI.

Related issue: envoyproxy#382
(needs a follow up to close, left in as a code-level todo).

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-review A PR waiting for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants