-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Test that we can produce artifacts with gcc #397
Conversation
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
- First iteration on testing gcc support in CI. This restricts the task to just building Nighthawk, and not testing it yet, as that needs a change in Envoy to go in first. - Small cleanup, and a bugfix for those who use the script to run locally, which would be detected as running in CircleCI. - [ ] Prerequisite: envoyproxy#394 Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
I plan to restart the CI tasks in here to get a sense of stability, as there are changes in here that impact memory requirements. |
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
It looks like that when building the asan task with 3 concurrent jobs we get “Too long with no output (exceeded 10m0s): context deadline exceeded”fairly structurally instead of it being oom killed occasionally :( the link steps are very memory hungry, maybe we need to lower parallelism further. It might then also be worth looking into a way to wrap ‘ld’ to serialize just the link calls and have the compile steps run at higher concurrency, as that may save some time. That’s quite hacky though. Maybe there’s also a larger build VM available that we can use for asan. Memory seems very tight for asan; it may take a long time otherwise (approx 1.5-2hours). |
force push to fix DCO Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
665b302
to
cd20455
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this coverage.
- First iteration on testing gcc support in CI. This restricts the task to just building Nighthawk, and not testing it yet, as that needs a change in Envoy to go in first. - Small cleanup, and a bugfix for those who use the script to run locally, which would be detected as running in CircleCI. Related issue: envoyproxy#382 (needs a follow up to close, left in as a code-level todo). Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
task to just building Nighthawk, and not testing it yet, as that
needs a change in Envoy to go in first.
locally, which would be detected as running in CircleCI.
Related issue: #382
(needs a follow up to close, left in as a code-level todo).
Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com