Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dubious90 to the list of owners. #524

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

dubious90
Copy link
Contributor

@dubious90 dubious90 commented Sep 10, 2020

Also explicitly add in some repo conventions about maintaining and contributing to nighthawk.

Signed-off-by: Nathan Perry nbperry@google.com

Nathan Perry and others added 2 commits September 10, 2020 18:04
Also add in recently discussed conventions about maintaining and
contributing to nighthawk.

Signed-off-by: Nathan Perry <nbperry@google.com>
Signed-off-by: dubious90 <dubious90@gmail.com>
@dubious90 dubious90 force-pushed the add-dubious90-maintainer branch from 8a2632c to dc186f7 Compare September 10, 2020 22:12
@dubious90 dubious90 marked this pull request as ready for review September 11, 2020 15:09
@dubious90 dubious90 requested a review from oschaaf September 11, 2020 15:09
@dubious90 dubious90 added the waiting-for-review A PR waiting for a review. label Sep 11, 2020
Copy link
Member

@oschaaf oschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@oschaaf oschaaf merged commit 4fe741b into envoyproxy:master Sep 11, 2020
@dubious90 dubious90 deleted the add-dubious90-maintainer branch April 26, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-review A PR waiting for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants