Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opt_build option to ci/do_ci.sh. #536

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

oschaaf
Copy link
Member

@oschaaf oschaaf commented Sep 15, 2020

This is helpful to assist with building Nighthawk's production
ready artifacts via docker build images.

For example:

DOCKER_IMAGE=envoyproxy/envoy-build-[centos|ubuntu] \
  ci/run_envoy_docker.sh ci/do_ci.sh opt_build

Related issue: #525

Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com

This is helpful to assist with building Nighthawk's production
ready artifacts via docker build images.

For example:

```bash
DOCKER_IMAGE=envoyproxy/envoy-build-[centos|ubuntu] \
  ci/run_envoy_docker.sh ci/do_ci.sh opt_build
```

Related issue: envoyproxy#525

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf oschaaf added the waiting-for-review A PR waiting for a review. label Sep 15, 2020
@dubious90 dubious90 self-assigned this Sep 15, 2020
Copy link
Contributor

@dubious90 dubious90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dubious90 dubious90 merged commit f434a43 into envoyproxy:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-review A PR waiting for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants