Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test benchmark docker image build in CI #537

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

oschaaf
Copy link
Member

@oschaaf oschaaf commented Sep 15, 2020

Now that we have a benchmark docker image build, it would be
good to make sure that keeps working in CI.

This also makes it easy to start pushing this image in CI in a
follow-up.

Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com

Now that we have a benchmark docker image build, it would be
good to make sure that keeps working in CI.

This also makes it easy to start pushing this image in CI in a
follow-up.

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf oschaaf added the waiting-for-review A PR waiting for a review. label Sep 15, 2020
@oschaaf
Copy link
Member Author

oschaaf commented Sep 15, 2020

/cc @abaptiste

Copy link
Contributor

@dubious90 dubious90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abaptiste
Copy link
Contributor

LGTM. Thank you!

@dubious90 dubious90 merged commit 398bd3e into envoyproxy:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-review A PR waiting for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants