Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Unknown Error 13 messages #600

Closed
wants to merge 106 commits into from
Closed

Improve Unknown Error 13 messages #600

wants to merge 106 commits into from

Conversation

eric846
Copy link
Contributor

@eric846 eric846 commented Dec 30, 2020 •
edited
Loading

Migrated to PR #666

Split error conditions as much as possible and add user guidance for further troubleshooting.

Nighthawk Service will now return a more specific error description for the following cases, instead of "unknown," for error 13.

  • URI exception, with user guidance to check for:
    • Malformed URI
    • DNS error
  • Failure predicate, with user guidance to check the output counters to narrow down:
    • Connection failures
      • Bad port
      • Bad address family (--address-family v4 or v6) especially when using 'localhost' or DNS
    • Stream resets (http/https, --h2)
    • 4xx or 5xx received
    • gRPC RequestSource error

The CLI output will also include the same new text.

#181 #613

eric846 added 30 commits June 1, 2020 17:23
@eric846
Merge pull request #5 from envoyproxy/master
8ea442d 
update from master
@eric846
Merge pull request #6 from envoyproxy/master
5ac755a 
merge from upstream
@eric846
Merge pull request #7 from envoyproxy/master
b8c25a5 
merge from upstream
@eric846
initial commit
1c19c68 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
fix comments
7050686 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
fix format
0776563 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
rename adaptive_rps to adaptive_load
16fd8f6 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
add field_selector in example
c383010 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
fix example comment
6e1a483 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
fix format
4ef1140 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
add support for fault injection headers
4111bf4 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
replace linear and binary search with exponential search
871a959 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
add InputVariableSetter mechanism
1fd77c1 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
add input variable setter to build file
edc36b2 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
fix syntax errors
4d0364e 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
rename samples/adaptive_rps
aed6d94 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
improve comments, change step controller initial value from int64 to …
d9ae87d 
…double

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
add proto validation rules, fix comments, make rps the default input_…
a05a6f5 
…variable_setter

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
fix comment wording
8cd4d21 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
simplify protos, add defaults, specify required or optional
d814a96 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
add missing newline
5f5a885 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
Kick CI
7e20a78 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
simplify protos
9048267 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
fix format
306c0ec 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
fix some optional field comments and rules
d33f543 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
Merge pull request #10 from envoyproxy/master
442cca9 
merge from upstream
@eric846
add Nighthawk status field in BenchmarkResult as nested nighthawk.cli…
677b783 
…ent.Output turns out not to include the status

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
switch to standard Envoy plugin config proto, add prefix to internal …
cefb366 
…plugin names, log thresholds only once per session

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
Merge remote-tracking branch 'upstream/master' into adaptive-rps-protos2
f3684df 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
create headers
5463051 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
eric846 added 6 commits March 8, 2021 16:30
@eric846
Merge remote-tracking branch 'upstream/main'
be5c0fa 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
Merge remote-tracking branch 'upstream/main'
7da182a 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
Merge remote-tracking branch 'upstream/main'
d3e5545 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
Merge branch 'main' into error13
32307e1 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
Merge remote-tracking branch 'upstream/main'
2f44065 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
Merge branch 'main' into error13
2cd7d47 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846 eric846 closed this Mar 16, 2021
@eric846
Copy link
Contributor Author

eric846 commented Mar 16, 2021

I'll reopen this after figuring out the test failures locally.

eric846 added 3 commits March 17, 2021 19:32
@eric846
Merge remote-tracking branch 'upstream/main'
190a691 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
Merge branch 'main' into error13
33d1913 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
fix integration test failures: avoid random failure predicate mismatc…
1035b2d 
…h again after having added a new one; add data dep for RequestSource yaml

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846 eric846 reopened this Mar 18, 2021
eric846 added 5 commits March 18, 2021 13:17
@eric846
Merge remote-tracking branch 'upstream/main'
74de764 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
return ok status when execution was cancelled
a27b30a 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
update process_test to anticipate ok status when cancelling
7bda479 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
Merge remote-tracking branch 'upstream/main'
c2baebd 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
Merge branch 'main' into error13
1d00bbb 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
Copy link
Contributor Author

eric846 commented Mar 19, 2021

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: integration_test_coverage (failed build)
🔨 rebuilding ci/circleci: tsan (failed build)
🔨 rebuilding ci/circleci: test_gcc (failed build)

🐱

Caused by: a #600 (comment) was created by @eric846.

see: more, trace.

@eric846
Copy link
Contributor Author

eric846 commented Mar 19, 2021

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: tsan (failed build)

🐱

Caused by: a #600 (comment) was created by @eric846.

see: more, trace.

@eric846
Copy link
Contributor Author

eric846 commented Mar 19, 2021

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: tsan (failed build)

🐱

Caused by: a #600 (comment) was created by @eric846.

see: more, trace.

eric846 added 6 commits March 22, 2021 17:27
@eric846
Merge remote-tracking branch 'upstream/main'
da83218 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
merge from upstream`
f954fca 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
Merge remote-tracking branch 'upstream/main'
e78adac 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
merge from upstream
aeb9882 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
Merge remote-tracking branch 'upstream/main'
f79c078 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
Merge branch 'main' into error13
e8f074c 
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846 eric846 closed this Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting-for-changes A PR waiting for comments to be resolved and changes to be applied.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eric846 @mum4k @oschaaf