Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Envoy to 9753819 (Jan 24th 2021). #607

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Update Envoy to 9753819 (Jan 24th 2021). #607

merged 2 commits into from
Jan 26, 2021

Conversation

mum4k
Copy link
Collaborator

@mum4k mum4k commented Jan 25, 2021

  • sync .bazelrc from envoy.
  • tryCreateNewConnection now returns a ConnPoolImplBase::ConnectionResult instead of a bool.

Signed-off-by: Jakub Sobon mumak@google.com

@mum4k
Update Envoy to 9753819 (Jan 24th 2021).
5f0b33f 
- tryCreateNewConnection now returns a
ConnPoolImplBase::ConnectionResult instead of a bool.

Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k mum4k requested a review from oschaaf January 25, 2021 04:58
@mum4k mum4k added the waiting-for-review A PR waiting for a review. label Jan 25, 2021
oschaaf
oschaaf approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@oschaaf oschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming that the PR that updates the docker version we use in CI resolves the CI glitch.

@oschaaf oschaaf removed the waiting-for-review A PR waiting for a review. label Jan 25, 2021
@mum4k mum4k merged commit 81bf056 into envoyproxy:main Jan 26, 2021
@mum4k mum4k deleted the envoy-update branch January 26, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oschaaf oschaaf oschaaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mum4k @oschaaf