feat: add http provider for rate limit config #362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbx-luxie
force-pushed
the
add-config-http-provider
branch
2 times, most recently
from
f4b2937
to
6d4a205
Compare
rbx-lwang
reviewed
Sep 15, 2022
rbx-lwang
reviewed
Sep 15, 2022
rbx-lwang
reviewed
Sep 15, 2022
rbx-lwang
reviewed
Sep 15, 2022
rbx-lwang
reviewed
Sep 15, 2022
rbx-lwang
reviewed
Sep 15, 2022
rbx-luxie
force-pushed
the
add-config-http-provider
branch
2 times, most recently
from
2060c5e
to
820da06
Compare
Signed-off-by: Lu Xie <luxie@roblox.com>
rbx-luxie
force-pushed
the
add-config-http-provider
branch
from
820da06
to
9ed8589
Compare
mattklein123
requested changes
Sep 30, 2022
Comment on lines
+532
to
+544
| ### From http provider | ||
|
|
||
| The Ratelimit service allows to load configuration from a http server. The endpoint can be configured via the settings package with the following environment variables: | ||
|
|
||
| ``` | ||
| HTTP_PROVIDER_ENABLED default:"false" | ||
| HTTP_PROVIDER_ENDPOINT | ||
| HTTP_PROVIDER_SUBPATH default:"" | ||
| HTTP_PROVIDER_POLL_INTERVAL default:"10" | ||
| HTTP_PROVIDER_POLL_TIMEOUT default:"10" | ||
| ``` | ||
|
|
||
| Configuration will be reloaded intervally according to the value of `HTTP_POLL_INTERVAL` (second). `HTTP_PROVIDER_SUBPATH` is an array which allows you to have multiple endpoints for different config files. |
There was a problem hiding this comment.
This needs a lot more documentation. Can you fully specify the proposed protocol and then we can go from there? Thanks.
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to have a method to load the rate limit config dynamically. This PR adds a simple http provider for feeding rate limit config to the Ratelimit service intervally.
Related github issue: #201