Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OSSF Score #1357

Merged
merged 11 commits into from
Dec 27, 2023
Merged

Improve OSSF Score #1357

merged 11 commits into from
Dec 27, 2023

Conversation

mmorel-35
Copy link
Collaborator

@mmorel-35 mmorel-35 commented Dec 27, 2023

This is related to #829

It provides two new workflows to provide advices in order to improve the security of toolshed and the dependent projects.

It also includes the definition of permissions and the use of sha instead of version.
No worries dependabot is able to update the sha and the version in the comment ;)

Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Copy link

netlify bot commented Dec 27, 2023

Deploy Preview for nifty-bassi-e26446 ready!

Name Link
🔨 Latest commit 7241c8b
🔍 Latest deploy log https://app.netlify.com/sites/nifty-bassi-e26446/deploys/658be6455778f9000823245a
😎 Deploy Preview https://deploy-preview-1357--nifty-bassi-e26446.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this @mmorel-35 - nice cleanups/additions

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/scorecard.yml Outdated Show resolved Hide resolved
mmorel-35 and others added 4 commits December 27, 2023 09:34
Co-authored-by: phlax <phlax@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 requested a review from phlax December 27, 2023 08:45
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits and then gtm, thanks @mmorel-35

.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/actions.yml Outdated Show resolved Hide resolved
mmorel-35 and others added 2 commits December 27, 2023 09:53
Co-authored-by: phlax <phlax@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mmorel-35

@phlax phlax merged commit 4c28ebd into envoyproxy:main Dec 27, 2023
22 checks passed
@mmorel-35 mmorel-35 deleted the security branch December 27, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants