Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support node metadata in aggregation rules #125

Open
jessicayuen opened this issue Aug 5, 2020 · 0 comments
Open

Support node metadata in aggregation rules #125

jessicayuen opened this issue Aug 5, 2020 · 0 comments
Assignees
@eapolinario
Labels
aggregation rules enhancement New feature or request

Comments

@jessicayuen
Copy link
Member

Support the freeform 'metadata' field in the aggregation rules.

API: https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/core/base.proto
@jessicayuen jessicayuen added enhancement New feature or request aggregation rules labels Aug 5, 2020
@eapolinario eapolinario mentioned this issue Aug 28, 2020
Merged
@eapolinario eapolinario mentioned this issue Sep 28, 2020
Merged
jyotimahapatra pushed a commit that referenced this issue Nov 19, 2020
Node metadata matcher (#154)
70181db 
This PR adds a matcher for node metadata fields. This is for #125.

Similarly to #137, we encode the node metadata information required in the aggregation rules in a pair of protos: (1) NodeMetadataMatch, and (2) NodeMetadataAction, the former related to the matching process, whereas the latter has to do with the formation of the fragment.

Envoy's node metadata is an opaque struct of type google.protobuf.Struct, which basically represents a dictionary of strings to Value.

This PR adds support for 3 of the 6 values: string, bool, and a nested struct of Value. The support for these other types is going to be added in separate PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eapolinario eapolinario

Labels
aggregation rules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eapolinario @jessicayuen