Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use race detector in go tests #210

Open
jyotimahapatra opened this issue Dec 4, 2020 · 0 comments
Open

Use race detector in go tests #210

jyotimahapatra opened this issue Dec 4, 2020 · 0 comments
Assignees
@pcalley

Comments

@jyotimahapatra
Copy link
Contributor

We should use -race in https://github.com/envoyproxy/xds-relay/blob/master/Makefile#L17 to make sure to avoid race conditions.
Adding the flag will expose some existing race conditions in code and test.
jyotimahapatra pushed a commit that referenced this issue Dec 17, 2020
Add -race detector to unit tests (#212)
74880d5 
Resolving data race in unit tests per: #210

Note: the -race flag has been omitted from this branch since there are remaining races that will be resolved in subsequent PR's.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcalley pcalley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jyotimahapatra and others