Fix compile warnings breaking builds with -Werror.

[LiSongMWO]

Ran into some problems pulling in hueplusplus into my project that uses strict flags for warnings.

Fixes some sign mismatches and implicit fall through and missing initializer.

[codecov]

Codecov Report

Merging #31 into master will increase coverage by 0.04%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   88.61%   88.66%   +0.04%     
==========================================
  Files          37       37              
  Lines        3592     3590       -2     
==========================================
  Hits         3183     3183              
+ Misses        409      407       -2     

Impacted Files	Coverage Δ
hueplusplus/LinHttpHandler.cpp	0.00% <0.00%> (ø)
hueplusplus/include/Hue.h	100.00% <ø> (ø)
hueplusplus/HueCommandAPI.cpp	98.24% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a3b8d6...36a58ad. Read the comment docs.

[enwi]

Hi @EmilyBjoerk and thanks for the work.

Have you checked if a modification of the included json library is really necessary?

The version we are using here is pretty old now and I saw a PR on that topic -> will this fix the issue as well? Then we can just update the library

[LiSongMWO]

Hi @EmilyBjoerk and thanks for the work.

Have you checked if a modification of the included json library is really necessary?

The version we are using here is pretty old now and I saw a PR on that topic -> will this fix the issue as well? Then we can just update the library

I think pulling a newer version from upstream might fix it, we can try that first.

[LiSongMWO]

Please let me know when you have updated the json library from upstream, their file structure seemed significantly different from what I saw in your repo. I'm not sure if they compile the source into one file or if your version is prior some refactoring so I'm not confident doing the update in this PR.

[enwi]

I switched to another JSON library nlohmann-json, which I wanted to do for some time now, the changes are on the development branch

[LiSongMWO]

I'm unfamiliar with your git workflow, looking at the history I would have expected to see back merges from master to development but it seems you rebase/cherrypick instead? I'm not quite sure how you want me to do this.

The changes I've made are basically trivial and I wonder if it isn't easier for you to just replicate them with your familiar workflows at this point? I've forked and fixed what I needed on my fork and now completed/deployed my project already so I'm not that concerned one way or another about the contribution "credit".

[enwi]

@EmilyBjoerk No worries, changes are pushed and pullrequests are merged with the development branch first, then once the changes have been checked and they're stable they get merged into the master branch technically creating a new version of the library. Maybe it's time to create a contribution guide.

Also nice project BTW 😄

[enwi]

@EmilyBjoerk I've tested your code with the changes made on the development branch and it all works fine.