Added AirDay, AirTime, Runtime and Status attributes to TV Show mappings #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to modify the package.json to ensure the Xml2Js package was only updating to the latest v0.2.x as there is a defect in 0.4.x where malformed XML throws an exception. See this issue: Leonidas-from-XIV/node-xml2js#118
|
The Travis CI build failed. Also, can you please change the patch to the develop branch? |
|
Also, the bugfix in xml2js was merged, so you could try 0.4.x again instead of depending on a rather old version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated via coffee script. Also updated unit tests and slight modification to the package.json - I made the xml2js version stay within v0.2.x as 0.4.x has a bug regarding text embedded within XML: Leonidas-from-XIV/node-xml2js#118