dev: minizip fdsafdsa

CoDeLib/Config.cmake.in

@@ -7,4 +7,6 @@ check_required_components(CoDeLib)
 include(CMakeFindDependencyMacro)
 
 set(ZLIB_USE_STATIC_LIBS "ON")
-find_dependency(ZLIB REQUIRED)
+find_dependency(ZLIB REQUIRED)
+
+find_dependency(minizip REQUIRED)

CoDeLib/Deflate_zlib/CMakeLists.txt

@@ -10,7 +10,6 @@ set(ZLIB_USE_STATIC_LIBS "ON")
 find_package(ZLIB REQUIRED)
 target_link_libraries(Deflate_zlib PRIVATE ZLIB::ZLIB)
 
-message(STATUS "CoDeLib_PUBLIC_INCLUDE_PATH: ${CoDeLib_PUBLIC_INCLUDE_PATH}")
 set(Deflate_zlib_PUBLIC_INCLUDE_PATH ${CoDeLib_PUBLIC_INCLUDE_PATH}/Deflate_zlib)
 set(Deflate_zlib_PUBLIC_HEADERS
     ${Deflate_zlib_PUBLIC_INCLUDE_PATH}/Deflate_zlib.h

CoDeLib/Zip_minizip/CMakeLists.txt

@@ -6,11 +6,9 @@ target_include_directories(Zip_minizip PUBLIC
     $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
 )
 
-set(ZLIB_USE_STATIC_LIBS "ON")
-find_package(ZLIB REQUIRED)
-target_link_libraries(Zip_minizip PRIVATE ZLIB::ZLIB)
+find_package(MINIZIP REQUIRED)
+target_link_libraries(Zip_minizip PRIVATE MINIZIP::minizip)
 
-message(STATUS "CoDeLib_PUBLIC_INCLUDE_PATH: ${CoDeLib_PUBLIC_INCLUDE_PATH}")
 set(Zip_minizip_PUBLIC_INCLUDE_PATH ${CoDeLib_PUBLIC_INCLUDE_PATH}/Zip_minizip)
 set(Zip_minizip_PUBLIC_HEADERS
     ${Zip_minizip_PUBLIC_INCLUDE_PATH}/Zip_minizip.h

CoDeLib/Zip_minizip/src/Zip_minizip.c

@@ -1,10 +1,16 @@
 #include <CoDeLib/Zip_minizip/Zip_minizip.h>
 
+#include <zip.h> // minizip
+
 ZIP_RETURN_CODES Zip(FILE *inputs[] __attribute__((unused)),
                      FILE *output __attribute__((unused)),
                      void *options __attribute__((unused))) {
 
-    return ZIP_SUCCESS;
+    // TODO: Dummy code to test if it compiles and links
+    if (ZIP_OK) {
+        return ZIP_SUCCESS;
+    }
+    return ZIP_ERROR;
 }
 
 const struct IZip zip_minizip = {

Scripts/BuildAndInstallCoDeLib.py

@@ -49,6 +49,9 @@ def BuildAndInstallCoDeLib(
     ExternalZlibLibInstallPath = Path(
         ExternalLibPath / "zlib/Install" / targetPlatformString / BuildTypeString
     )
+    ExternalMinizipNgLibInstallPath = Path(
+        ExternalLibPath / "minizip-ng/Install" / targetPlatformString / BuildTypeString
+    )
 
     CoDeLibRootPath = Path(RepositoryRootPath / ProjectName)
     BuildDirectory = Path(
@@ -70,14 +73,15 @@ def BuildAndInstallCoDeLib(
     print("==============================")
     print(ProjectName + ": Configuring ({})".format(BuildTypeString))
     print("==============================")
-    configureCommand = 'cmake -G "{0}" -DCMAKE_TOOLCHAIN_FILE="{1}" -S "{2}" -B "{3}" -DCMAKE_INSTALL_PREFIX="{4}" -DZLIB_ROOT="{5}" -DCMAKE_BUILD_TYPE={6}'.format(
+    configureCommand = 'cmake -G "{0}" -DCMAKE_TOOLCHAIN_FILE="{1}" -S "{2}" -B "{3}" -DCMAKE_INSTALL_PREFIX="{4}" -DCMAKE_BUILD_TYPE={5} -DZLIB_ROOT="{6}" -DCMAKE_PREFIX_PATH="{7}"'.format(
         buildEnv.GetCmakeGenerator(),
         buildEnv.GetCustomToolChainPath(),
         CoDeLibRootPath,
         BuildDirectory,
         InstallDirectory,
-        ExternalZlibLibInstallPath,
         BuildTypeString,
+        ExternalZlibLibInstallPath,
+        ExternalMinizipNgLibInstallPath,
     )
     print(configureCommand)
     subprocess.run(

Scripts/BuildAndInstallExternalLibs.py

@@ -112,8 +112,92 @@ def BuildAndInstallZlib(
     )
 
 
+##############################
+# minizip-ng
+##############################
+def BuildAndInstallMinizipNg(
+    buildEnv: EnvironmentConfig.EnvironmentConfiguration,
+    buildConfig: EnvironmentConfig.BuildConfig = EnvironmentConfig.BuildConfig.DEBUG,
+):
+    ProjectName = "minizip-ng"
+
+    BuildTypeString = EnvironmentConfig.BuildConfig.ToCMakeBuildType(buildConfig)
+    targetPlatformString = EnvironmentConfig.Platform.PlatformToOsName(
+        buildEnv.GetTargetPlatform()
+    )
+
+    TopLevelCMakeListsDirectory = Path(ExternalLibPath / ProjectName)
+    BuildDirectory = Path(
+        ExternalLibPath / ProjectName / "Build" / targetPlatformString / BuildTypeString
+    )
+    InstallDirectory = Path(
+        ExternalLibPath
+        / ProjectName
+        / "Install"
+        / targetPlatformString
+        / BuildTypeString
+    )
+
+    if not BuildDirectory.exists():
+        BuildDirectory.mkdir(parents=True)
+
+    if InstallDirectory.exists():
+        shutil.rmtree(InstallDirectory)
+        InstallDirectory.mkdir(parents=True)
+
+    os.chdir(RepositoryRootPath)
+
+    # All options for minizip-ng that are not needed are turned off (all off them) except for MZ_COMPAT
+    # In this project minizing-ng is used only for zip file creation and extraction
+    print("==============================")
+    print(ProjectName + ": Configuring ({})".format(BuildTypeString))
+    print("==============================")
+    configureCommand = 'cmake -G "{0}" -DCMAKE_TOOLCHAIN_FILE="{1}" -S {2} -B {3} -DCMAKE_INSTALL_PREFIX="{4}" -DCMAKE_BUILD_TYPE={5} -DBUILD_SHARED_LIBS=OFF -DMZ_COMPAT=ON -DMZ_ZLIB=OFF -DMZ_BZIP2=OFF -DMZ_LZMA=OFF -DMZ_ZSTD=OFF -DMZ_LIBCOMP=OFF -DMZ_FETCH_LIBS=OFF -DMZ_PKCRYPT=OFF -DMZ_WZAES=OFF -DMZ_OPENSSL=OFF -DMZ_LIBBSD=OFF -DMZ_ICONV=OFF'.format(
+        buildEnv.GetCmakeGenerator(),
+        buildEnv.GetCustomToolChainPath(),
+        TopLevelCMakeListsDirectory,
+        BuildDirectory,
+        InstallDirectory,
+        BuildTypeString,
+    )
+    print(configureCommand)
+    subprocess.run(
+        configureCommand,
+        shell=True,
+        check=True,
+    )
+
+    print("==============================")
+    print(ProjectName + ": Building ({})".format(BuildTypeString))
+    print("==============================")
+    buildCommand = "cmake --build {0}".format(BuildDirectory)
+    print(buildCommand)
+    subprocess.run(
+        buildCommand,
+        shell=True,
+        check=True,
+    )
+
+    print("==============================")
+    print(ProjectName + ": Installing ({})".format(BuildTypeString))
+    print("==============================")
+    installCommand = "cmake --install {0}".format(BuildDirectory)
+    print(installCommand)
+    subprocess.run(
+        installCommand,
+        shell=True,
+        check=True,
+    )
+
+
 BuildEnv = EnvironmentConfig.EnvironmentConfiguration(
     RepositoryRootPath, targetPlatform
 )
+
+# zlib
 BuildAndInstallZlib(BuildEnv, EnvironmentConfig.BuildConfig.DEBUG)
 BuildAndInstallZlib(BuildEnv, EnvironmentConfig.BuildConfig.RELEASE)
+
+# minizip-ng
+BuildAndInstallMinizipNg(BuildEnv, EnvironmentConfig.BuildConfig.DEBUG)
+BuildAndInstallMinizipNg(BuildEnv, EnvironmentConfig.BuildConfig.RELEASE)

Scripts/BuildBenchmark.py

@@ -55,6 +55,9 @@ def BuildBenchmark(
     ExternalZlibLibInstallPath = Path(
         ExternalLibPath / "zlib/Install" / targetPlatformString / BuildTypeString
     )
+    ExternalMinizipNgLibInstallPath = Path(
+        ExternalLibPath / "minizip-ng/Install" / targetPlatformString / BuildTypeString
+    )
 
     BenchmarkRootPath = Path(RepositoryRootPath / ProjectName)
     BuildDirectory = Path(
@@ -69,14 +72,15 @@ def BuildBenchmark(
     print("==============================")
     print(ProjectName + ": Configuring ({})".format(BuildTypeString))
     print("==============================")
-    configureCommand = 'cmake -G "{0}" -DCMAKE_TOOLCHAIN_FILE="{1}" -DCMAKE_PREFIX_PATH="{2}" -S {3} -B {4} -DZLIB_ROOT="{5}" -DCMAKE_BUILD_TYPE={6}'.format(
+    configureCommand = 'cmake -G "{0}" -DCMAKE_TOOLCHAIN_FILE="{1}" -S {2} -B {3} -DCMAKE_BUILD_TYPE={4} -DZLIB_ROOT="{5}" -DCMAKE_PREFIX_PATH="{6};{7}"'.format(
         buildEnv.GetCmakeGenerator(),
         buildEnv.GetCustomToolChainPath(),
-        CoDeLibInstallDirectory,
         BenchmarkRootPath,
         BuildDirectory,
-        ExternalZlibLibInstallPath,
         BuildTypeString,
+        ExternalZlibLibInstallPath,
+        CoDeLibInstallDirectory,
+        ExternalMinizipNgLibInstallPath,
     )
     subprocess.run(
         configureCommand,

Scripts/CleanAll.py

@@ -16,13 +16,17 @@
 ExternalLibPath = Path(ProjectRootPath / "External")
 ExternalZlibLibBuildPath = Path(ExternalLibPath / "zlib/Build")
 ExternalZlibLibInstallPath = Path(ExternalLibPath / "zlib/Install")
+ExternalMinizipNgLibBuildPath = Path(ExternalLibPath / "minizip-ng/Build")
+ExternalMinizipNgLibInstallPath = Path(ExternalLibPath / "minizip-ng/Install")
 
 DirectoriesToRemove = [
     BenchmarkBuildPath,
     CoDeLibBuildPath,
     CoDeLibInstallPath,
     ExternalZlibLibBuildPath,
     ExternalZlibLibInstallPath,
+    ExternalMinizipNgLibBuildPath,
+    ExternalMinizipNgLibInstallPath,
 ]