fix: reanimated crashes on the latest version, example app crashes #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ords in example app
MatiPl01
commented
Jul 24, 2024
| @@ -62,7 +62,7 @@ export default function App() { | |||
| y: cy.value, | |||
| } | |||
| }, | |||
| onActive: ({ translationX, translationY }, context) => { | |||
There was a problem hiding this comment.
This was also incorrect and this example didn't work. The context variable is declared above in the component, so it overrode the variable with undefined.
|
Hi @MatiPl01 thanks a lot for spending time on this PR, I'm sincerely grateful for that. The changes make perfect sense and I will include them in the next version soon. I'm really sorry for the late response |
enzomanuelmangano
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes unnecessary
Animated.createAnimatedComponentcall for theCanvascomponent, which causes crashes on the latestreact-native-reanimatedversion. Since it is not necessary (it takes neither animated style, nor animated props), it can be removed.I also added missing
'worklet'keywords in gesture handler functions in the example app which were missing and caused crashes for the rect component.I bumped
react-native-gesture-handlerand added'worklet'keyword to callbacks declared on the gesture in thesrc/canvas/canvas.tsxcomponent as gesture handler started to show warnings in the latest version when'worklet'is missing.Repro
You can see the issues I described in the repro on this repository (the
mainbranch).Patched library with changes from this PR is included in the
patchedbranch.