Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion tagName tries to shallowrender the given component #13

Open
marcodejongh opened this issue Jan 21, 2016 · 4 comments
Open

Assertion tagName tries to shallowrender the given component #13

marcodejongh opened this issue Jan 21, 2016 · 4 comments
Labels

Comments

@marcodejongh
Copy link
Contributor

When using the following assertion:

expect(wrapper.children().at(1)).to.have.tagName('td');

I get a error because on of the props of the child of the wrapper at 1 is undefined.

If I remove the tagName assertion and just leave this one:

 expect(wrapper.children().at(1)).to.have.prop('className', 'action');

The error is gone. So there is a discrepancy between how to.have.prop and to.have.tagName do their assertions.

@vesln
Copy link
Contributor

vesln commented Jan 21, 2016

@marcodejongh that's sadly correct.

for various reasons, we had to implement it this way initially and we decided to release with it (it's not a 1.0 release, so didn't bother me too much).

we should fix this as soon as we can. if you would like to submit a pr it will be very welcome!

@vesln vesln added the bug label Jan 21, 2016
@marcodejongh
Copy link
Contributor Author

Could you make sure that you assign issues that you're picking up? I have 20% time tomorrow so I intend to fix all issues raised by me. I went ahead with making these issues to get some discussion going about them

@vesln
Copy link
Contributor

vesln commented Jan 21, 2016

@marcodejongh i just added you as a collaborator to the project. me and the rest of the team are super thankful to all people who are willing to contribute to our projects, so this is our way to say "thank you".

feel free to assign yourself to whatever you would like to tackle. i'd personally love another person start digging inside the project, as i'm sure that you'll be able to find more issues and potential improvements that we could introduce.

@albertogasparin
Copy link

Sorry guys, any update on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants