Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module export #27

Merged
merged 1 commit into from
Feb 1, 2016
Merged

Module export #27

merged 1 commit into from
Feb 1, 2016

Conversation

ayrton
Copy link
Contributor

@ayrton ayrton commented Feb 1, 2016

People who don't use babel currently have to do:

var chai-enzyme = require('chai-enzyme').default
// vs.
var chai-enzyme = require('chai-enzyme')

As suggested @ljharb in #16:

Consumers should never have to interact with babel's CommonJS interop

@vesln
Copy link
Contributor

vesln commented Feb 1, 2016

👍

1 similar comment
@andreasklinger
Copy link

👍

@ayrton ayrton merged commit ec08495 into master Feb 1, 2016
@ayrton ayrton deleted the module-exports branch February 1, 2016 14:15
@ljharb
Copy link
Member

ljharb commented Feb 1, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayrton @vesln @andreasklinger @ljharb