parent() api does not return children in shallow rendering

[VidyullathaKandipati]

I am trying to get the second child element from the parent and it fails. Below is the example:

Component:

class TestComponent extends React.Component {
  render() {
    return (
      <div id="root">
        <div id="parent1" className="parentOne">
          <div id="child1_1" className="childOne">
            Hello world!
          </div>
          <div id="child1_2" className="childTwo">
            Hello world!
          </div>
        </div>
        <div id="parent2">
          <div id="child2_1">
            Hello world!
          </div>
          <div id="child2_2">
            Hello world!
          </div>
        </div>
      </div>
    );
  }
}

TestComponent.displayName = 'TestComponent';

export default TestComponent;

Test:

it('renders parent1 children', () => {
    const wrapper = shallow(<TestComponent />);

    const child1 = wrapper.find('#child1_1');
    const parent1 = child1.parent();
    expect(parent1).to.have.className('parentOne');

    const child12 = parent1.childAt(1);
    expect(child12).to.have.className('childTwo');
  });

The second assertion fails with the below error message:

AssertionError: expected the node in <TestComponent /> to have a 'childTwo' class, but it has undefined

And when I log parent1.children(), I get ShallowWrapper { length: 0 }.

Strangely, expect(child12).to.be.present(); passes.

[tkrotoff]

I'm having the same issue with Enzyme 3 (was working with Enzyme 2):

test('parent() vs parents()', () => {
  const H1 = () => (
    <h1 />
  );

  const root = shallow(
    <div id="root">
      <H1 />
      <h2 />
      <h3 />
    </div>
  );

  console.log('root:', root.debug());

  const h1 = root.find(H1);
  console.log('h1.parent():', h1.parent().debug());
  console.log('h1.parents():', h1.parents().debug());
});

Output:

    root: <div id="root">
      <H1 />
      <h2 />
      <h3 />
    </div>

    // ===> Something wrong:
    h1.parent(): <div id="root" />
    //

    h1.parents(): <div id="root">
      <H1 />
      <h2 />
      <h3 />
    </div>

To sum-up child.parent() does not contain its children while child.parents() does.

[ljharb]

@tkrotoff @VidyullathaKandipati what version of react are you both using?

[VidyullathaKandipati]

I am using react: 15.6.2 and enzyme-adapter-react-15: 1.0.1

[tkrotoff]

React 16.0.0 + enzyme-adapter-react-16 1.0.1

[alecmerdler]

I am also having this issue with react@16.0.0 and enzyme-adapter-react-16@1.0.4.

[nbkhope]

I have tests that pass for Enzyme v2. They do the following:

wrapper.find('label[htmlFor="something"]').parent().children().at(1).text()

Now it does not pass anymore in v3. What should I do? I'm just checking the text of the label's sibling (that is not inside any particular tag).

• Using React 16.2.0

Console logging the parent()'s children() yields nothing while the parent() yields:

// .parent().debug()
<ParentComponent someProp={true} />

[ljharb]

@nbkhope try adding .hostNodes() after .children()?

[nbkhope]

@ljharb

ShallowWrapper::getNodes() is no longer supported. Use ShallowWrapper::getElements() instead

I tried getElements(), but it returns an empty list. But I went from child to parent and the parent exists, so how can there be no children?

Update:

Sorry, I should have used .hostNodes(). Anyway, it yields a similar result:

console.log(....parent().children().hostNodes());
// => ShallowWrapper { length: 0 }

So I get nothing.

[nbkhope]

I was kind of reluctant to upgrade to v3 right away, but decided to give it a try. Now am kind of reluctant again. Anyway, I can make my tests pass using the .parents() like so:

// before
wrapper.find('label[htmlFor="something"]').parent().children().at(1).text()

// after
wrapper.find('label[htmlFor="something"]').parents().at(0).children().at(1).text()

Please fix that issue :)

[ljharb]

If you start with wrapper.find('label[htmlFor="something"]').hostNodes(), does that help?

[nbkhope]

@ljharb that does not seem to do anything.

Doing wrapper.find('label[htmlFor="something"]').hostNodes().parent() returns the parent, but then appending a .children() yields nothing:

console.log(wrapper.find('label[htmlFor="something"]').hostNodes().parent().children())
// => ShallowWrapper { length: 0 }

PS: Using Enzyme v3.2.0

[ljharb]

Gotcha, thanks - that seems to be the OP's issue as well.

[rixth]

Seeing similar issue with enzyme@3.2.0, enzyme-adapter-react-15@1.0.5

const Cmp = () => (
  <div>
    <section>
      FOO
      <h1>BAR</h1>
    </section>
  </div>
);

const wrapper = shallow(<Cmp />);
console.log(wrapper.debug());
console.log('h1 parent text:', wrapper.find('h1').parent().text());
console.log(wrapper.find('h1').parent().debug());

Output:

<div>
  <section>
    FOO
    <h1>
      BAR
    </h1>
  </section>
</div>
h1 parent text:
<section />

I would expect .text() not to return a blank string, and for .parent().debug() not to show an empty <section/> tag.

If I replace .parent() with .parents().at(0) things work as expected.

[ljharb]

This has been resolved; as the tests in #769 indicate.

Please file a new issue if not.