Add tests on broken .parent() use-case #769
Conversation
|
(linking to #410) |
test/ReactWrapper-spec.jsx
Outdated
| it('should work with components in the tree', () => { | ||
| const Foo = () => (<div className="bar" />); | ||
| const wrapper = mount(<Foo />); | ||
| expect(wrapper.find('.bar').parent()).to.equal(wrapper.find('Foo')); |
There was a problem hiding this comment.
I'm not convinced this should actually work - Foo isn't supposed to be in the tree at all; only what Foo renders is.
There was a problem hiding this comment.
Maybe, not sure what should be at the right side. I haven't had a chance to look what it returns because it fails now.
There was a problem hiding this comment.
Could you add a similar test to ShallowWrapper, so we can compare the behaviors?
There was a problem hiding this comment.
Done. Shallow wrapper returns empty wrapper in this case.
Also, I have updated test for mounted wrapper. Now it expects that it has.root as a parent. It is not possible to do the same for shallow because it doesn't render components deeply.
|
Hello, @ljharb |
test/ShallowWrapper-spec.jsx
Outdated
| }, | ||
| }); | ||
| const wrapper = shallow(<Foo />); | ||
| expect(wrapper.find('.bar').parent()).to.have.length(0); |
There was a problem hiding this comment.
In this case, .find('.bar') is the root - I'm not even sure .find('.bar') will find anything. Could you add an assertion that wrapper.find('.bar') has length 1?
There was a problem hiding this comment.
Done.
Shallow test is still passing, mounted is not.
src/MountedTraversal.js
Outdated
| @@ -257,7 +257,7 @@ export function pathToNode(node, root) { | |||
| } | |||
|
|
|||
| export function parentsOfInst(inst, root) { | |||
| return pathToNode(inst, root).reverse(); | |||
| return (pathToNode(inst, root) || []).reverse(); | |||
There was a problem hiding this comment.
it seems to me that pathToNode should just always return an array instead of having this || [] logic.
There was a problem hiding this comment.
When I change that, another test breaks that I can't figure out. I'll push that commit up so you can play with it.
|
any reason this was abandoned? |
|
@alexreardon it's not abandoned, it's just that nobody's provided a fix yet. I updated the PR just a few days ago |
|
I missed that. Cheers |
|
@alexreardon if you're looking for a quick (bad, slow) workaround: const parent = ofNode => ofNode.root.findWhere(n => n.node == ofNode.node.parentNode);warning: you probably shouldn't use this because its a pretty gross hack and quite slow |
|
any updates? |
|
No updates; but I think this is the same as #1235 |
|
This appears to have been addressed in v3, as the tests are now passing. I'm going to merge the tests and close the linked issue. |
When I traverse through React components in a mounted tree, it can't find parent and fails with the error
See added test as a reproduction example.
As far as I could track, it happens, because the node can't find itself because component wrapper the wrong children
wrapper.children()in this test returns an empty array, however we have a node inside.