React hooks test case part 3 -- useCallback #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`shallow`: Note that the `get same callback when using `useCallback` and rerender with same prop in dependencies` is skipped because react shallow renderer doesn't memoize callback function value. Pending facebook/react#15774
ljharb
reviewed
May 31, 2019
There was a problem hiding this comment.
Since facebook/react#15774 is a bug, it'd be good to find a way to work around it before the bugfix is available.
ljharb
force-pushed
the
usecallback-test
branch
2 times, most recently
from
f7897d4
to
9cc5f44
Compare
|
I just sent a PR for this in facebook/react#15843 ; As for bugfix in enzyme side, I'm not sure what the way is -- inherit |
|
We could stub |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are almost as same as #2144 , but for
useCallback.And I saw that shallow renderer doesn't memoize the callback between two rendering even the dependencies not change. So the test in chenesan@5cc14ba#diff-2e9c9c89f001140a7699819fc2f5d926R1252 will fail and I temporarily skip it. Have opened an issue in react (facebook/react#15774) . If it's confirmed as a bug of shallow renderer then I'll try to fix it in react side.