[fix] Allow developing without nvm/root #2223
Conversation
env.js
Outdated
| run('npm', 'i', '--no-save', ...installs), | ||
| Promise.all( | ||
| rmrfs.map(s => primraf(s)) | ||
| ).then(() => run('npm', 'i', '--no-save', ...installs)), |
There was a problem hiding this comment.
The previous npm i in this script readds the node_modules/npm link... so it has to be removed before this npm i --no-save otherwise the same problem just happens again.
|
On the contrary; we’re all (me) using nvm, so no root access is required. I’d suggest that approach. |
|
@ljharb I'd suggest just merging this so that people don't have to use nvm if they don't want to. I'm just about to push an improvement though, so hang on a few minutes. |
|
Okay all done now. |
insidewhy
changed the title
|
Hm... travis is failing on stuff not related to this PR at all. mega-shrug. Also noticed the |
|
I believe the 16.9 release broke some of our tests; I'll rebase and merge this once master is passing again. |
|
@ljharb Cool thanks. I'll resume work on the hooks support once that is done. As of now, I can't get the tests to pass reliably even once I revert all my changes and use the pure github master. I tried them in the node:10, node:11 and node:12 containers so there shouldn't be anything about my system interfering here. |
|
@ohjames the tests are broken on master with the release of react 16.9; all work on enzyme is blocked on fixing that. I'll merge this as soon as I can get master passing again. |
|
@ohjames i've rebased this, but the tests are failing legitimately. |
|
@insidewhy are you no longer interested in this PR? |
See my comments in #2086
I assume that some changes happened to
lernawhich broke theenv.jsscript. I assume the people developing onenzymerecently are all doing so withrootaccess. Naughty!Anyway, this fixes it. Now I can develop.