Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug introduced in #677 #680

Merged
merged 6 commits into from
Dec 22, 2016
Merged

Fix bug introduced in #677 #680

merged 6 commits into from
Dec 22, 2016

Commits on Dec 22, 2016

  1. added 2 more tests for hasClass on composite components 

    - passing test for composite component that renders composite component which itself renders a dom element
- failing test for composite component that renders null
    @nfcampos
    nfcampos authored and Nuno Campos committed Dec 22, 2016
    Configuration menu
    Copy the full SHA
    bfc6dd3 View commit details
    Browse the repository at this point in the history

  2. fix for calling hasClass on component that renders null

    @nfcampos
    nfcampos authored and Nuno Campos committed Dec 22, 2016
    Configuration menu
    Copy the full SHA
    79a70c4 View commit details
    Browse the repository at this point in the history

  3. stricter condition following React documentationa 

    see https://facebook.github.io/react/docs/react-dom.html#finddomnode for return values of findDOMNode
    @nfcampos
    nfcampos authored and Nuno Campos committed Dec 22, 2016
    Configuration menu
    Copy the full SHA
    6456995 View commit details
    Browse the repository at this point in the history

  4. Add test for hasClass used on SFCs, Remove limitation for use of getD… 

    …OMNode on SFCs
    @nfcampos
    nfcampos authored and Nuno Campos committed Dec 22, 2016
    Configuration menu
    Copy the full SHA
    4d0eb62 View commit details
    Browse the repository at this point in the history

  5. Fix typo

    @nfcampos
    nfcampos authored and Nuno Campos committed Dec 22, 2016
    Configuration menu
    Copy the full SHA
    cb1daad View commit details
    Browse the repository at this point in the history

  6. Test error messages for getDOMNode

    @nfcampos
    nfcampos authored and Nuno Campos committed Dec 22, 2016
    Configuration menu
    Copy the full SHA
    fc2fef0 View commit details
    Browse the repository at this point in the history