Make displayNameOfNode return function.name even if it is falsey #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- previously it would return the function itself
ljharb
approved these changes
Apr 10, 2017
test/Utils-spec.jsx
Outdated
| @@ -598,6 +598,14 @@ describe('Utils', () => { | |||
| expect(displayNameOfNode(<Foo />)).to.equal('Foo'); | |||
| }); | |||
|
|
|||
| it('should return the name even if it is falsey', () => { | |||
nfcampos
added a commit
to kentcdodds/enzyme
that referenced
this pull request
Apr 10, 2017
see PR enzymejs#878 for explanation
nfcampos
force-pushed
the
fix/displayName-falsey
branch
2 times, most recently
from
e4e04bd to
a2c6d5a
Compare
ljharb
force-pushed
the
fix/displayName-falsey
branch
from
a2c6d5a to
85447ed
Compare
nfcampos
added a commit
to kentcdodds/enzyme
that referenced
this pull request
Apr 10, 2017
see PR enzymejs#878 for explanation
ljharb
pushed a commit
to kentcdodds/enzyme
that referenced
this pull request
Apr 12, 2017
see PR enzymejs#878 for explanation
ljharb
pushed a commit
to kentcdodds/enzyme
that referenced
this pull request
Apr 12, 2017
see PR enzymejs#878 for explanation
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously it would return the function itself, which is strange,
displayNameOfNodeshould return either a string or null@ljharb this can (should?) be merged before #876
found this because the changes in #876 made us start using
createClassinstead ofReact.createClassin the tests to create createClass components, which made this babel plugin https://babeljs.io/docs/plugins/transform-react-display-name/ stop adding the variable name as displayName to these components and thus those tests started failing withAssertionError: expected [Function] to equal 'Foo'(example failure at https://travis-ci.org/airbnb/enzyme/jobs/220197356#L4836)(the tests should probably be removed, because they seem to be testing a babel plugin instead of enzyme)