Tentative refactoring of convert HF #156
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer
This was only tested on a few models for now. We shall test on a wider panel (like #146) to make sure we did not loose some compatibility.
Rationale
The
convert HF
entrypoint has grown quite extensively to support various models and architectures along the way, and is becoming hard to follow.This PR aims at laying out some form of structure to facilitate the understanding, maintenance and extendability of the tool.
Main concepts
Here are some of the main changes:
run()
method more readable;TODO
model-validator
recipe to validate compatibility;Feedback welcome! Any ideas to make this complex but nonetheless crucial script better are worth sharing!