Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: record unique request_id for every request #17

Merged
merged 6 commits into from
Oct 23, 2023
Merged

feat!: record unique request_id for every request #17

merged 6 commits into from
Oct 23, 2023

Conversation

PortableNavi
Copy link
Contributor

@PortableNavi PortableNavi commented Oct 22, 2023

Adds a feature flag (which currently is enabled by default) to attach a unique request ID to each request

resolves: #16

@PortableNavi PortableNavi changed the title Added request_id feature request_id feature Oct 22, 2023
@PortableNavi
Copy link
Contributor Author

PortableNavi commented Oct 23, 2023

I just noticed that I've changed some of the crate meta data in Cargo.toml like the crate name, repo url and author fields when I made my fork. Should I update this pull request so that those changes are reverted or can these be excluded during merging?

@eopb
Copy link
Owner

eopb commented Oct 23, 2023

I just noticed that I've changed some of the crate meta data in Cargo.toml like the crate name, repo url and author fields when I made my fork. Should I update this pull request so that those changes are reverted or can these be excluded during merging?

No worries, I'm happy to push commits to undo those. If you'd like to do it that's also fine.

@eopb eopb changed the title request_id feature feat!: record unique request_id for every request Oct 23, 2023
@eopb eopb merged commit 5a74abe into eopb:master Oct 23, 2023
@eopb
Copy link
Owner

eopb commented Oct 23, 2023

Thanks for your contribution @PortableNavi 🚀

I've cut a release https://github.com/eopb/tide-tracing/releases/tag/v0.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attach request_id for each request
2 participants