Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new parameter of the GetTableRows api #138

Merged
merged 3 commits into from
Apr 21, 2020
Merged

add new parameter of the GetTableRows api #138

merged 3 commits into from
Apr 21, 2020

Conversation

crazybits
Copy link
Contributor

No description provided.

Copy link
Contributor

@maoueh maoueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you apply the suggestion change on the comment formatting, I'll merge de PR.

responses.go Outdated
@@ -234,7 +234,7 @@ type GetTableRowsRequest struct {
KeyType string `json:"key_type,omitempty"` // The key type of --index, primary only supports (i64), all others support (i64, i128, i256, float64, float128, ripemd160, sha256). Special type 'name' indicates an account name.
Index string `json:"index_position,omitempty"` // Index number, 1 - primary (first), 2 - secondary index (in order defined by multi_index), 3 - third index, etc. Number or name of index can be specified, e.g. 'secondary' or '2'.
EncodeType string `json:"encode_type,omitempty"` // The encoding type of key_type (i64 , i128 , float64, float128) only support decimal encoding e.g. 'dec'" "i256 - supports both 'dec' and 'hex', ripemd160 and sha256 is 'hex' only
Reverse bool `json:"Reverse,omitempty"` //get rows in reverse of the index
Reverse bool `json:"reverse,omitempty"` //get rows in reverse of the index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Reverse bool `json:"reverse,omitempty"` //get rows in reverse of the index
Reverse bool `json:"reverse,omitempty"` // Get rows in reverse of the index

Copy link
Contributor Author

@crazybits crazybits Apr 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done @maoueh

@maoueh maoueh merged commit 0a84410 into eoscanada:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants