Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a check for int overflows in ReadByteArray #219

Merged
merged 2 commits into from
Oct 29, 2024
Merged

added a check for int overflows in ReadByteArray #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b67e236
check for int overflow in ReadByteArray()
fschoell Oct 29, 2024
60f66a2
add changelog
fschoell Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Unreleased

* Added a check for int overflows in `ReadByteArray`
* Changed valueToInt, valueToUint, valueToFload function in abiencode.go for compatible with double quoted string to number.
* Changed `NewAssetFromString` validation to allow parsing of empty assets
* Added `action_trace_v1` field
Expand Down
4 changes: 4 additions & 0 deletions decoder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,6 +631,10 @@ func (d *Decoder) ReadByteArray() (out []byte, err error) {
return nil, err
}

if l > math.MaxInt || d.pos > math.MaxInt-int(l) {
return nil, errors.New("byte array: varlen is overflowing int")
}

if len(d.data) < d.pos+int(l) {
return nil, fmt.Errorf("byte array: varlen=%d, missing %d bytes", l, d.pos+int(l)-len(d.data))
}
Expand Down
Loading