This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
Removed unused dependencies including 'eosjs-ecc' #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellytran3k
requested review from
RaycatWhoDat,
ericpassmore,
juanm95 and
AlexGriffith10
|
I see the yarn.lock still there and modified, but your comment said you deleted it, maybe it got added back on or something? |
juanm95
reviewed
Apr 25, 2023
package.json
Outdated
| "@types/node": "^14.18.36", | ||
| "@types/node-fetch": "^2.5.11", | ||
| "@types/pako": "^1.0.2", | ||
| "@types/jest": "^29.5.1", |
There was a problem hiding this comment.
I see that jest got updated to 29 from 26, might be best to have that upgrade happen as a separate ticket in case that jump adds to our package size or causes something else unexpected. Same thing for the "npm" package that gets added below.
There was a problem hiding this comment.
fixed! thanks! also w the yarn.lock thing idk why I thought I deleted it lolol, but I just modified the description.
…ed-text-endcoding fix: remove deprecated text-encoding package and replace with utils v…
Change calls to substr to use substring instead
|
validated docs generation with the command |
- kept text-encoding from head - removed unused deps
ericpassmore
approved these changes
Apr 26, 2023
This was referenced Apr 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Fixes these relevant issues: #57, #59
I removed unused dependencies including
eosjs-eccby scoping outdepcheckand runningnpm test-allafter everynpm uninstall <unused_dependency>Dependencies removed:
I also modified the
package.jsonfile's scripts to runnpminstead ofyarn. This is a part of #12. Further clean up will be done in a separate ticket.Testing
I used modified version of
npm test-allto test against the removed dependencies.NOTE: Cypress test was failing. Investigation could be further discussed with team.