Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue where the knowledge base cannot be edited when using ve… #1519

Merged
merged 1 commit into from
May 14, 2024

Conversation

jsRuner
Copy link
Contributor

@jsRuner jsRuner commented May 14, 2024

…ctor type other than chrome

Description

When the vector database is not in Chroma, errors may occur when editing Arguments in the knowledge base.
The error exception is Invalid request

The reason traced back to the cause is a problem with the code logic

Request=SpaceServeRequest (id=space. id)
Update_request=self. to_request (space)
Query=self_ Create_query_object (session, request)
Entry=query. first()
If entry is None:
Raise Exception ("Invalid request")

What is expected here is to query records based on their IDs,
But the actual query conditions are ID and vectortype
Because vector type provides a default value of Chroma
Causing query failure.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, it's very helpful. r+

Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Aries-ckt Aries-ckt merged commit 8b88f7e into eosphoros-ai:main May 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants