Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Solve the problem of invalid subgraph naming when creating tugraph #1731

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

A-Salty-Fish
Copy link
Contributor

description: 使用 tugraph 时,前端的命名约束中会允许 "-" , 但在 tugraph 中此类命名是不允许的,会出现创建失败的问题;连带会错误创建已有知识库并且无法删除。

image
image
image

description: 使用 tugraph 时,前端的命名约束中会允许 "-" , 但在 tugraph 中此类命名是不允许的,会出现创建失败的问题;连带会错误创建已有知识库并且无法删除。
@github-actions github-actions bot added the fix Bug fixes label Jul 16, 2024
@Aries-ckt Aries-ckt changed the title fix: 解决创建tugraph的无效子图命名问题 fix: Solve the problem of invalid subgraph naming when creating tugraph Jul 16, 2024
@csunny
Copy link
Collaborator

csunny commented Jul 19, 2024

@A-Salty-Fish
Thanks for PR, can you fix the format error? You can follow this document and fix this
https://github.com/eosphoros-ai/DB-GPT/blob/main/CONTRIBUTING.md

@A-Salty-Fish
Copy link
Contributor Author

Sure, I'll following the document to fix the format error.

@A-Salty-Fish
Copy link
Contributor Author

I find that your makefile wouldn't work well on Windows platfrom with GNU. There are some command conflit when run make fmt on Windows, for exampled the 'touch' command .
When I use Liunx platform, it works well. I think it's better to fix the makefile or write some tips to avoid others wasting time running it on Windows.

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@Aries-ckt Aries-ckt merged commit 84988b8 into eosphoros-ai:main Jul 22, 2024
2 checks passed
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants