Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rag): Fix bug fail to delete files when deleting the knowledge space #2185

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

toralee
Copy link
Contributor

@toralee toralee commented Dec 8, 2024

Description

Fix delete the knowldege uploading file in the 'pilot/data' when deleteing the space by dbgpt CLI. There's no dependencies that are required for this change.

How Has This Been Tested?

On the command terminal, executing dbgpt knowledge load --space_name testnewspace --local_doc_path \testpath\testfile.txt, and then executing dbgpt knowledge delete --sapce_name testnewspace. From observing the direcotry $(dbgpt_path)/pilot/data/.

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. LGTM

@fangyinc fangyinc changed the title Fix bug fail to delete files when deleting the knowledge space fix(rag): Fix bug fail to delete files when deleting the knowledge space Dec 11, 2024
@github-actions github-actions bot added the fix Bug fixes label Dec 11, 2024
Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR.
LGTM.

@fangyinc fangyinc merged commit 23aedea into eosphoros-ai:main Dec 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants