Adding support for SMART_DETECT_LINE events #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires patching of the uiprotect library first - currently does not get returned as a Device event (event.type.value in EventType.device_events_set()). Confirmed a patch to uiprotect will result in LINE detections working with this adjustment. Will reopen the pull request if I can get the change done on uiprotect. |
|
Thanks for this! Its been a long lingering to do so it will be great to get that closed off |
|
Looks like this was added in v6.1.0 of the uiprotect library. Can this be merged into unifi-protect-backup now? |
|
I've reopened this pull request. Are you able to also bump the version of ui protect used as part of this or? |
ep1cman
force-pushed
the
smart-detect-line
branch
from
89f8baa
to
a4cfce4
Compare
Unifi Protect has started to return events that have not ended. These are now explicitly filtered out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusting the types to include support for SMART_DETECT_LINE.
Closes #69
Could similarly add support for Audio detections, Smart Detect animals, etc. in the future but the DETECTION_TYPES parameter could become unwieldly.
Tested with:
Python 3.12.6
UnifiOS 4.0.6
Protect 4.1.53
NOTE: This will often result in duplicate or very similar events being uploaded as Protect can trigger as both a Smart Detect Zone and Smart Detect Line event at the same time, depending on your settings.
e.g. a Person crosses a Line and there is also an active Smart Detect Zone setup at the same location.