Skip to content

Commit

Permalink
Workflow: Move model notification up to top-level
Browse files Browse the repository at this point in the history
Simplifies the workflow by removing nested templates. I.e. instead of having
a template consisting of building-then-post-service, we add the building
and service-posting as top-level tasks in do-all, and add the builder as a
dependency of the service.

Needed beause of argoproj/argo-workflows#1713
  • Loading branch information
Erik Parmann committed Nov 14, 2019
1 parent da1844c commit 13037f3
Showing 1 changed file with 9 additions and 30 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1275,35 +1275,6 @@ spec:
template: gordo-watchman-to-postgres
{% endif %}


- name: build-single-machine
inputs:
parameters:
- name: model-name
- name: model-config
- name: metadata
- name: data-config
- name: data-provider
- name: evaluation-config
steps:
- - name: build-model
template: model-builder
arguments:
parameters: [{name: model-name, value: {{ '"{{inputs.parameters.model-name}}"' }} },
{name: model-config, value: {{ '"{{inputs.parameters.model-config}}"' }} },
{name: metadata, value: {{'"{{inputs.parameters.metadata}}"'}} },
{name: data-config, value: {{ '"{{inputs.parameters.data-config}}"' }}},
{name: data-provider, value: {{ '"{{inputs.parameters.data-provider}}"' }}},
{name: evaluation-config, value: {{ '"{{inputs.parameters.evaluation-config}}"' }}}
]
- - name: model-notification-svc
template: gordo-notification-svc
arguments:
parameters:
- name: model-name
value: {{ '"{{inputs.parameters.model-name}}"' }}
- name: host-name
value: "ml-server-{{ project_name }}"
- name: ml-server
inputs:
parameters:
Expand Down Expand Up @@ -1333,7 +1304,7 @@ spec:
- ensure-single-workflow
{% for machine in machines %}
- name: model-builder-{{ machine.name }}
template: build-single-machine
template: model-builder
arguments:
parameters: [{name: model-name, value: "{{ machine.name }}"},
{name: model-config, value: "{{ machine.model }}"},
Expand All @@ -1345,6 +1316,14 @@ spec:
dependencies:
- watchman
- ml-server
- name: model-notification-{{ machine.name }}
template: gordo-notification-svc
arguments:
parameters: [{name: model-name, value: "{{ machine.name }}"},
{name: host-name, value: "ml-server-{{ project_name }}"}
]
dependencies:
- model-builder-{{ machine.name }}
{% endfor %}
- name: postgres-cleanup
template: postgres-cleanup
Expand Down

0 comments on commit 13037f3

Please sign in to comment.