Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix rules/named-export: False positive detection of ExportNamedDeclaration in TSModuleBlock #198

Merged
merged 3 commits into from
Nov 22, 2020

Conversation

epaew
Copy link
Owner

@epaew epaew commented Nov 22, 2020

Related issue numbers

About the pull request

The rule named-export reports the warning "The export name must match the filename. You need to rename to Espree or espree" with below case;

  • @types/espree.d.ts
/// <reference types="estree" />

declare module 'espree' {
  // eslint-disable-next-line @typescript-eslint/no-explicit-any
  export function parse(code: string, options?: any): Node;
}

But this behavior is not what I expected, so I fix it.

Additional context

Add any other context for this pull request here.

@epaew epaew force-pushed the bugfix/named-export_in_TSModuleBlock branch from e4628e1 to 5ff49b4 Compare November 22, 2020 03:11
@epaew epaew changed the title Bugfix rules/named-export: aggressive detects ExportNamedDeclaration in TSModuleBlock Bugfix rules/named-export: False positive detection of ExportNamedDeclaration in TSModuleBlock Nov 22, 2020
@epaew epaew force-pushed the bugfix/named-export_in_TSModuleBlock branch from 5ff49b4 to 2c36015 Compare November 22, 2020 03:56
@epaew epaew marked this pull request as ready for review November 22, 2020 03:59
@codeclimate
Copy link

codeclimate bot commented Nov 22, 2020

Code Climate has analyzed commit 2c36015 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (60% is the threshold).

This pull request will bring the total coverage in the repository to 94.4% (0.0% change).

View more on Code Climate.

@epaew epaew merged commit 08aabda into master Nov 22, 2020
@epaew epaew deleted the bugfix/named-export_in_TSModuleBlock branch November 22, 2020 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant