Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add hydrogens for aromatic bonds outside the ring - system throws exception #1579

Closed
AlexeyGirin opened this issue Jan 17, 2024 · 7 comments · Fixed by #1615
Closed

Comments

@AlexeyGirin
Copy link
Collaborator

Environment details (please complete the following information):

Describe the bug
Unable to add hydrogens for aromatic bonds outside the ring - system throws exception

Steps to Reproduce

  1. Load from file: Unable to add hydrogens for aromatic bonds outside the ring - system throws exception.zip (unzip first)
  2. Press Add/Remove explicit hydrogens button
    image

Actual behavior
System throws exception: IndigoException: element: can not calculate implicit hydrogens on aromatic C, charge 0, degree 1, 0 radical electrons
image
image
uat.test.lifescience.opensource.epam.com-1705525259112.log

Expected behavior
image

@AliaksandrDziarkach
Copy link
Collaborator

This is not query related issue.
If you add 'aromatic' for any atom to use query molecule mode you can see that it will work

@AliaksandrDziarkach
Copy link
Collaborator

I have no idea why "aromatic" bond placed in query bonds in ketcher.
This is just a normal bond like single/double/triple.
For example: if you add cyclohexane and change all bonds to aromatic - after change last bond to aromatic it will be re-drawn as aromatic benzene.

@AlexeyGirin
Copy link
Collaborator Author

Should not throw exceptopn

@AlexeyGirin
Copy link
Collaborator Author

No exception now - good, but works wrong (Version 1.18.0-rc.5.0-gb21ab5ad5-wasm32-wasm-clang-12.0.0)
Actual behavior:
image

Expected behavior:
image

@AlexeyGirin AlexeyGirin reopened this Jan 29, 2024
@AlexeyGirin AlexeyGirin removed this from the Indigo-1.18.0-rc.5 milestone Feb 2, 2024
@AlexeyGirin
Copy link
Collaborator Author

MOved to RC7 as per @vanoprenko decision

@AlexeyGirin
Copy link
Collaborator Author

MOved to 1.19 as per @vanoprenko decision

@AlexeyGirin
Copy link
Collaborator Author

MOved to #1915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment