Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotests: Adding/Removing hydrogens works correct for bonds #3959

Closed
43 tasks done
AlexeyGirin opened this issue Jan 25, 2024 · 0 comments · Fixed by #4211
Closed
43 tasks done

Autotests: Adding/Removing hydrogens works correct for bonds #3959

AlexeyGirin opened this issue Jan 25, 2024 · 0 comments · Fixed by #4211
Assignees
Milestone

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jan 25, 2024

Description:
Bunch of test cases validates that user can add remove hydrogens for molecules connected by different type of bonds
Related implementation tasks: epam/Indigo#1436 and #3685

All test cases below are blocked by:

Test case 1:

  • User can expand hydrogens for molecules connected by different type of bonds

Preconditions:
Clear canvas
Open from file: All types of bond.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 2:

Preconditions:
Clear canvas
Open from file: All types of bond - Chain topology.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 3:

Preconditions:
Clear canvas
Open from file: All types of bond - Chain topology - Center reaction center.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 4:

Preconditions:
Clear canvas
Open from file: All types of bond - Chain topology - Made broken and changes reaction center.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 5:

Preconditions:
Clear canvas
Open from file: All types of bond - Chain topology - Made broken reaction center.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 6:

Preconditions:
Clear canvas
Open from file: All types of bond - Chain topology - No change reaction center.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 7:

Preconditions:
Clear canvas
Open from file: All types of bond - Chain topology - Not center reaction center.zip
(unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 8:

Preconditions:
Clear canvas
Open from file: All types of bond - Chain topology - Order changes reaction center.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 9:

Preconditions:
Clear canvas
Open from file: All types of bond - Either topology - Center reaction center.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 10:

Preconditions:
Clear canvas
Open from file: All types of bond - Either topology - Made-Broken and changes reaction center.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 11:

Preconditions:
Clear canvas
Open from file: All types of bond - Either topology - Mad-broken reaction center.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 12:

Preconditions:
Clear canvas
Open from file: All types of bond - Either topology - No change reaction center.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 13:

Preconditions:
Clear canvas
Open from file: All types of bond - Either topology - Not center reaction center.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 14:

Preconditions:
Clear canvas
Open from file: All types of bond - Either topology - Order changes reaction center.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 15:

Preconditions:
Clear canvas
Open from file: All types of bond - Ring topology.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 16:

Preconditions:
Clear canvas
Open from file: All types of bond - Ring topology - Center reaction center.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 17:

Preconditions:
Clear canvas
Open from file: All types of bond - Ring topology - Made-Broken and changes reaction center.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 18:

Preconditions:
Clear canvas
Open from file: All types of bond - Ring topology - Made-broken reaction center.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 19:

Preconditions:
Clear canvas
Open from file: All types of bond - Ring topology - No change reaction center.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 20:

Preconditions:
Clear canvas
Open from file: All types of bond - Ring topology - Not center reaction center.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 21:

Preconditions:
Clear canvas
Open from file: All types of bond - Ring topology - Order changes reaction center.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 22:

Preconditions:
Clear canvas
Open from file: All Custom Query Bonds.zip (unzip first)

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas (most bonds should be converted except long custom query one in addition to adding hydogens)
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 23:

  • User can expand hydrogens for molecules connected by different type of bonds having Query feature atom on the canvas

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 24:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Chain topology.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 25:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Chain topology - Center reaction center.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 26:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Chain topology - Made broken and changes reaction center.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 27:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Chain topology - Made broken reaction center.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 28:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Chain topology - No change reaction center.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 29:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Chain topology - Not center reaction center.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 30:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Chain topology - Order changes reaction center.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 31:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Either topology - Center reaction center.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 32:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Either topology - Made-Broken and changes reaction center.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 33:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Either topology - Made-broken reaction center.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 34:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Either topology - No change reaction center.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 35:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Either topology - Not center reaction center.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 36:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Either topology - Order changes reaction center.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 37:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Ring topology.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 38:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Ring topology - Center reaction center.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 39:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Ring topology - Made-Broken and changes reaction center.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 40:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Ring topology - Made-broken reaction center.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 41:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Ring topology - No change reaction center.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 42:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Ring topology - Not center reaction center.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

Test case 43:

Preconditions:
Clear canvas
Open from file (unzip first): All types of bond with Query feature atom on the canvas - Ring topology - Order changes reaction center.zip

Main steps:
Press Add/Remove explicit hydrogens button
Validate canvas
Press Add/Remove explicit hydrogens button
Validate canvas

@AlexeyGirin AlexeyGirin added this to the Autotests milestone Jan 25, 2024
@AlexeyGirin AlexeyGirin changed the title Autotests: Adding/Removing hydrogens works correct from bonds Autotests: Adding/Removing hydrogens works correct for bonds Feb 2, 2024
@AlexeyGirin AlexeyGirin linked a pull request Mar 7, 2024 that will close this issue
9 tasks
AlexeyGirin added a commit that referenced this issue Mar 8, 2024
…4211)

* Added tests, ket files and reference screenshots for issue #3959

* Added tests, ket files and reference screenshots for issue #3959 - 2

* Update for 2-Molecules-connected-by-All-Custom-Query-Bonds-ket-1 screenshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants