Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDX loader crashed on some files with abbreviations #1697

Closed
AliaksandrDziarkach opened this issue Feb 13, 2024 · 1 comment · Fixed by #1699 or #1713
Closed

CDX loader crashed on some files with abbreviations #1697

AliaksandrDziarkach opened this issue Feb 13, 2024 · 1 comment · Fixed by #1699 or #1713
Assignees
@AliaksandrDziarkach
Labels
Bug Priority: High
Milestone
Indigo-1.18.0-rc.8

Comments

@AliaksandrDziarkach
Copy link
Collaborator

Environment details (please complete the following information):
image

Describe the bug
Ketcher cannot open some CDX with abbreviations.

Steps to Reproduce

  1. Unzip provided file:
  2. Open file in ketcher
  3. Error occured

Expected behavior
Molecule should be added to canvas:
image

Actual behavior
image

Attachments
unspecified_with_abbreviation.zip

Root cause
Usually abbreviations in CDX has type "4 Nickname" or "5 Fragment", but some has type "0 Unspecified". Such abbreviations cause exception in CDX loader.
@AliaksandrDziarkach AliaksandrDziarkach self-assigned this Feb 13, 2024
AliaksandrDziarkach added a commit that referenced this issue Feb 13, 2024
@AliaksandrDziarkach
#1697 CDX loader crashed on some files with abbreviations
ec1533d 
Fix code and UTs. Add UT.
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Feb 13, 2024 that will close this issue
#1697 CDX loader crashed on some files with abbreviations #1699
Merged
8 tasks
@AliaksandrDziarkach AliaksandrDziarkach mentioned this issue Feb 14, 2024
Closed
AliaksandrDziarkach added a commit that referenced this issue Feb 16, 2024
@AliaksandrDziarkach
#1697 CDX loader crashed on some files with abbreviations (#1699)
20f34cc
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Feb 16, 2024 that will close this issue
Backmerge: #1697 CDX loader crashed on some files with abbreviations #1713
Merged
4 tasks
AlexanderSavelyev pushed a commit that referenced this issue Feb 16, 2024
@AliaksandrDziarkach
Backmerge: #1697 CDX loader crashed on some files with abbreviations (#…
7b39822 
…1713)
@AlexeyGirin
Copy link
Collaborator

Verified.
Indigo Toolkit Version 1.18.0-rc.7.0-g8a5c36802-x86_64-linux-gnu-11.2.1
Ketcher Version 2.19.0-rc.1 Build at 2024-02-19; 15:33:56
Firefox Version 122.0.1 (64-bit)
Win10
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Bug Priority: High
Projects
None yet
Milestone
Indigo-1.18.0-rc.8
2 participants
@AliaksandrDziarkach @AlexeyGirin