Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Cannot load Peptides from our Library that are not connected by bonds using FASTA file #1881

Closed
NadezhdaPeskun opened this issue Mar 27, 2024 · 1 comment · Fixed by #1897 or #1896
Closed

Macro: Cannot load Peptides from our Library that are not connected by bonds using FASTA file #1881

NadezhdaPeskun opened this issue Mar 27, 2024 · 1 comment · Fixed by #1897 or #1896
Assignees
@AliaksandrDziarkach
Labels
Bug epic: macromolecules FASTA Bucket: FASTA related issues pre-done Priority: High
Milestone
Indigo-1.19.0-rc.3

Comments

@NadezhdaPeskun
Copy link
Collaborator

NadezhdaPeskun commented Mar 27, 2024 •
edited
Loading

Steps to Reproduce

  1. Switch to Macromolecules mode
  2. Load from file: Cannot load back Peptides from Library using FASTA.zip
    Important: do not connect peptides with bonds!
  3. Save to FASTA format
  4. Open this Fasta as Peptides

Actual behavior
When trying to open a file system throws exception: Convert error! array: invalid index 4 (size=4)
image

Expected behavior
All Peptides not connected by bonds should be opened from saved FASTA file.

Environment details:
Ketcher Version 2.20.0-rc.2 Build at 2024-03-27; 08:30:51
Indigo Toolkit Version 1.19.0-rc.2.0-g6c0e3fecf-x86_64-linux-gnu-11.2.1
Win10
Chrome Version 122.0.6261.129 (Official Build) (64-bit)

Related issues:
@NadezhdaPeskun NadezhdaPeskun added Bug FASTA Bucket: FASTA related issues labels Mar 27, 2024
@NadezhdaPeskun NadezhdaPeskun added this to the Waiting for triage milestone Mar 27, 2024
@NadezhdaPeskun NadezhdaPeskun changed the title Cannot add several Peptides to Canvas from FASTA Cannot add several Peptides from Labrary to Canvas from FASTA Mar 27, 2024
@NadezhdaPeskun NadezhdaPeskun mentioned this issue Mar 27, 2024
Open
@AlexeyGirin AlexeyGirin changed the title Cannot add several Peptides from Labrary to Canvas from FASTA Macro: Cannot add several Peptides from Labrary to Canvas from FASTA Mar 27, 2024
@AlexeyGirin AlexeyGirin changed the title Macro: Cannot add several Peptides from Labrary to Canvas from FASTA Macro: Cannot save and load back Peptides from Library from FASTA Mar 27, 2024
@AlexeyGirin AlexeyGirin changed the title Macro: Cannot save and load back Peptides from Library from FASTA Macro: Cannot save and load back Peptides from Library using FASTA Mar 27, 2024
@Zhirnoff Zhirnoff changed the title Macro: Cannot save and load back Peptides from Library using FASTA Macro: Cannot load Peptides from our Library that are not connected by bonds using FASTA file Mar 28, 2024
@NadezhdaPeskun NadezhdaPeskun mentioned this issue Mar 28, 2024
Closed
@AliaksandrDziarkach AliaksandrDziarkach self-assigned this Apr 2, 2024
AliaksandrDziarkach added a commit that referenced this issue Apr 2, 2024
@AliaksandrDziarkach
#1881 Macro: Cannot load Peptides from our Library that are not conn…
e975296 
…ected by bonds using FASTA file

Fix fragment index. Add UT
AliaksandrDziarkach added a commit that referenced this issue Apr 2, 2024
@AliaksandrDziarkach
#1881 Macro: Cannot load Peptides from our Library that are not conn…
3f29bcc 
…ected by bonds using FASTA file

Fix fragment index. Add UT
AliaksandrDziarkach added a commit that referenced this issue Apr 2, 2024
@AliaksandrDziarkach
Backmerge: #1881 Macro: Cannot load Peptides from our Library that ar…
1b7e907 
…e not connected by bonds using FASTA file

Fix fragment index. Add UT
This was linked to pull requests Apr 2, 2024
Backmerge: #1881 Macro: Cannot load Peptides from our Library that are not connected by bonds using FASTA file #1897
Merged
#1881 Macro: Cannot load Peptides from our Library that are not connected by bonds using FASTA file #1896
Merged
AliaksandrDziarkach added a commit that referenced this issue Apr 2, 2024
@AliaksandrDziarkach
Backmerge: #1881 Macro: Cannot load Peptides from our Library that ar…
fe00419 
…e not connected by bonds using FASTA file (#1897)
AlexanderSavelyev pushed a commit that referenced this issue Apr 2, 2024
@AliaksandrDziarkach
#1881 Macro: Cannot load Peptides from our Library that are not conn…
07f453b 
…ected by bonds using FASTA file (#1896)
@NadezhdaPeskun
Copy link
Collaborator Author

NadezhdaPeskun commented Apr 4, 2024 •
edited
Loading

Done for СI
Version 2.20.0-rc.2
Build at 2024-04-04; 11:31:49

Indigo Toolkit
Version 1.19.0-rc.3.0-gf2d7689b-wasm32-wasm-clang-12.0.0

image
image

@github-project-automation github-project-automation bot moved this to Done in Indigo Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Bug epic: macromolecules FASTA Bucket: FASTA related issues pre-done Priority: High
Projects
Indigo
Status: Done
Milestone
Indigo-1.19.0-rc.3
3 participants
@AliaksandrDziarkach @AlexeyGirin @NadezhdaPeskun