Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro and macro structures connected through attachment points cannot be saved in CML format in micro mode #1990

Closed
Zhirnoff opened this issue Jun 6, 2024 · 3 comments · Fixed by #2026 or #2024
Assignees
Labels
Bug CML Bucket: CML format related issues Priority: High

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jun 6, 2024

Summary
Micro and macro structures connected through attachment points cannot be saved in CML format in micro mode

Steps to Reproduce

  1. Open Ketcher.
  2. Draw a benzene ring
  3. Add an attachment point to the benzene ring via right click menu
  4. Switch to Macro mode and connect attachment point to a macro structure
  5. Switch to Micro mode
  6. Save structure in CML format

If it is not possible to draw the structure, then you can open the prepared file (you just need to open it in macro mode and then switch to micro mode):
ketcher (53).zip

Expected behavior
Micro and macro structures connected through attachment points can be saved in CML format in micro mode

Actual behavior
Micro and macro structures connected through attachment points cannot be saved in CML format in micro mode
2024-06-06_15h28_47
2024-06-06_15h29_25
2024-06-06_15h29_33

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.2]
Indigo version
[Version 1.21.0-rc.1]

Refers to feature: epam/ketcher#4530

@Zhirnoff Zhirnoff added Bug Priority: High CML Bucket: CML format related issues labels Jun 6, 2024
@Zhirnoff Zhirnoff added this to the Indigo-1.21.0-rc.2 milestone Jun 6, 2024
@AlexeyGirin AlexeyGirin self-assigned this Jul 4, 2024
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Jul 4, 2024

Tested. Bug fixed. Micro and macro structures can be saved in CML format but cannot be opened. Registered bug: #2084
2024-07-04_15h59_51

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.23.0-rc.1]
Indigo version
[Version 1.22.0-rc.1]

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jul 4, 2024

Have to be checked in version 1.21.0-rc.3

@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Jul 4, 2024

Tested. Bug for saving is fixed but when we loadind it a mess. We have bug for it for Indigo 1.22.0-rc.1 but with another behaviour #2084
2024-07-04_19h05_08
Saved CML file: ketcher (5).zip

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.8]
Indigo version
[Version 1.21.0-rc.3]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment