Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1993 - Micro and macro structures connected through attachment points cannot be opened after save in CDXML format in micro mode #2008

Merged
merged 5 commits into from
Jun 18, 2024
Merged

#1993 - Micro and macro structures connected through attachment points cannot be opened after save in CDXML format in micro mode #2008

merged 5 commits into from
Jun 18, 2024

Conversation

even1024
Copy link
Collaborator

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

@even1024 even1024 changed the title #1994 - Micro and macro structures connected through attachment points cannot be opened after save in CDX and Base 64CDX format in micro mode #1993 - Micro and macro structures connected through attachment points cannot be opened after save in CDXML format in micro mode Jun 18, 2024
@even1024 even1024 linked an issue Jun 18, 2024 that may be closed by this pull request
Micro and macro structures connected through attachment points cannot be opened after save in CDXML format in micro mode #1993
Closed
AliaksandrDziarkach
AliaksandrDziarkach approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@AliaksandrDziarkach AliaksandrDziarkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@even1024 even1024 merged commit 4ce1776 into master Jun 18, 2024
66 checks passed
@even1024 even1024 deleted the 1994-monomer-superatom-cdxml branch June 18, 2024 12:30
even1024 added a commit that referenced this pull request Jun 19, 2024
@even1024
#1993 - Micro and macro structures connected through attachment point…
60393da 
…s cannot be opened after save in CDXML format in micro mode (#2008)
@even1024 even1024 linked an issue Jun 26, 2024 that may be closed by this pull request
Micro and macro structures connected through attachment points cannot be saved in CML format in micro mode #1990
Closed
@even1024 even1024 removed a link to an issue Jun 26, 2024
Micro and macro structures connected through attachment points cannot be saved in CML format in micro mode #1990
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliaksandrDziarkach AliaksandrDziarkach AliaksandrDziarkach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@even1024 @AliaksandrDziarkach