Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro and macro structures connected through attachment points cannot be opened after save in CDX and Base 64CDX format in micro mode #1994

Closed
Zhirnoff opened this issue Jun 6, 2024 · 2 comments · Fixed by #2024 or #2026
Labels
Bug Export to CDX Bucket: Bugs related to Export to CDX Priority: High

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jun 6, 2024

Summary
Micro and macro structures connected through attachment points cannot be opened after save in CDX and Base 64CDX format in micro mode

Steps to Reproduce

  1. Open Ketcher.
  2. Draw a benzene ring
  3. Add an attachment point to the benzene ring via right click menu
  4. Switch to Macro mode and connect attachment point to a macro structure
  5. Switch to Micro mode
  6. Save structure in CDXML format
  7. Open saved file

If it is not possible to draw the structure, then you can open the prepared file (you just need to open it in macro mode and then switch to micro mode):
ketcher (53).zip

Actual behavior
Micro and macro structures connected through attachment points cannot be opened after save in CDX and Base 64CDX format in micro mode

2024-06-06_16h24_23
2024-06-06_16h24_33
2024-06-06_16h24_41

Expected behavior
Micro and macro structures connected through attachment points can be opened after save in CDX and Base 64CDX format in micro mode
2024-06-06_14h02_50

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.2]
Indigo version
[Version 1.21.0-rc.1]

Refers to feature: epam/ketcher#4530

Attached saved files:
ketcherCDX (1).zip

@Zhirnoff Zhirnoff added Bug Priority: High Export to CDX Bucket: Bugs related to Export to CDX labels Jun 6, 2024
@Zhirnoff Zhirnoff added this to the Indigo-1.21.0-rc.2 milestone Jun 6, 2024
even1024 added a commit that referenced this issue Jun 26, 2024
…s cannot be opened after save in CDX and Base 64CDX format in micro mode (#2024)
even1024 added a commit that referenced this issue Jun 26, 2024
…s cannot be opened after save in CDX and Base 64CDX format in micro mode (#2024)
even1024 added a commit that referenced this issue Jun 26, 2024
…hment points cannot be opened after save in CDX and Base 64CDX format in micro mode (#2026)
@AnnaKosol
Copy link
Collaborator

When opening a file with a cdxml format, a modal window with an error is displayed
Снимок экрана 2024-07-03 в 16 11 13
When opening a file with a b64cdx format, a modal window with an error is displayed
Снимок экрана 2024-07-03 в 16 14 26

Versions:
Ketcher Version 2.23.0-rc.1 Build at 2024-07-02; 09:03:38
Indigo Version 1.21.0-rc.1.0-g9194599b2-x86_64-linux-gnu-11.2.1
MacOs Sonoma version 14.5
Chrome Version 126.0.6478.127 (Официальная сборка), (arm64)

@AnnaKosol AnnaKosol reopened this Jul 3, 2024
@AlexeyGirin AlexeyGirin modified the milestones: Indigo-1.21.0-rc.3, Indigo-1.21.0-rc.4 Jul 4, 2024
@AlexeyGirin
Copy link
Collaborator

Verified.
image

  • Ketcher Version 2.22.0-rc.9 Build at 2024-07-04; 15:58:14
  • Indigo Toolkit Version 1.21.0-rc.3.0-g1570d3f9f-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

@AlexeyGirin AlexeyGirin modified the milestones: Indigo-1.21.0-rc.4, Indigo-1.21.0-rc.3 Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment