Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export of CHEM-Nucleotide to HELM is wrong #2077

Closed
AlexeyGirin opened this issue Jul 3, 2024 · 1 comment · Fixed by #2090 or #2091
Closed

Export of CHEM-Nucleotide to HELM is wrong #2077

AlexeyGirin opened this issue Jul 3, 2024 · 1 comment · Fixed by #2090 or #2091
Assignees
@AliaksandrDziarkach
Labels
Bug HELM Bucket: Bugs related to Export to HELM format Priority: High
Milestone
Indigo-1.22.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Go to Macromolecules mode - Flex mode
  2. Load from file: Export of CHEM-Nucleotide to HELM is wrong.zip
    image
  3. Save canvas to HELM

Actual behavior
Export result contains wrong chains: CHEM1{[MCC]}|RNA1{R(U)P}$CHEM1,RNA1,1:R1-1:R2$$$V2.0
image

Expected behavior
Export result is correct: CHEM1{[MCC]}|RNA1{R(U)P}$CHEM1,RNA1,1:R1-3:R2$$$V2.0

Versions

  • Ketcher Version 2.23.0-rc.1 Build at 2024-07-02; 08:57:41
  • Indigo Toolkit Version 1.22.0-rc.1.0-g2bef0ce6c-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Issue found while testing - #1188
@AlexeyGirin AlexeyGirin added Bug Priority: High HELM Bucket: Bugs related to Export to HELM format labels Jul 3, 2024
@AlexeyGirin AlexeyGirin added this to the Indigo-1.22.0-rc.2 milestone Jul 3, 2024
AliaksandrDziarkach added a commit that referenced this issue Jul 5, 2024
@AliaksandrDziarkach
#2077 Export of CHEM-Nucleotide to HELM is wrong
d4258c3 
Fix typo. Add UT
AliaksandrDziarkach added a commit that referenced this issue Jul 5, 2024
@AliaksandrDziarkach
Backmerge: #2077 Export of CHEM-Nucleotide to HELM is wrong
4d8c46c 
backmerge to master
@AliaksandrDziarkach AliaksandrDziarkach self-assigned this Jul 5, 2024
This was linked to pull requests Jul 5, 2024
#2077 Export of CHEM-Nucleotide to HELM is wrong #2090
Merged
Backmerge: #2077 Export of CHEM-Nucleotide to HELM is wrong #2091
Merged
AliaksandrDziarkach added a commit that referenced this issue Jul 8, 2024
@AliaksandrDziarkach
#2077 Export of CHEM-Nucleotide to HELM is wrong (#2090)
a287d19
AliaksandrDziarkach added a commit that referenced this issue Jul 8, 2024
@AliaksandrDziarkach
Backmerge: #2077 Export of CHEM-Nucleotide to HELM is wrong (#2091)
8147b45
@AlexeyGirin
Copy link
Collaborator Author

Fixed.
image

  • Ketcher Version 2.23.0-rc.2 Build at 2024-07-10; 19:39:22
  • Indigo Toolkit Version 1.22.0-rc.2.0-ga21fb5d8f-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Bug HELM Bucket: Bugs related to Export to HELM format Priority: High
Projects
None yet
Milestone
Indigo-1.22.0-rc.2
2 participants
@AliaksandrDziarkach @AlexeyGirin