Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout for 1-step reactions is broken #2213

Closed
even1024 opened this issue Aug 11, 2024 · 2 comments · Fixed by #2214 or #2220
Closed

Layout for 1-step reactions is broken #2213

even1024 opened this issue Aug 11, 2024 · 2 comments · Fixed by #2214 or #2220
Assignees
@even1024
Milestone
Indigo-1.23.0-rc.2

Comments

@even1024
Copy link
Collaborator

Steps to Reproduce

  1. Draw any reaction:

image

  1. Apply layout

Expected behavior
image

Actual behavior
image
@even1024 even1024 self-assigned this Aug 11, 2024
@even1024 even1024 added this to the Indigo-1.24.0-rc.1 milestone Aug 11, 2024
@even1024 even1024 changed the title Lauout for 1-step reactions is broken Layout for 1-step reactions is broken Aug 11, 2024
@even1024 even1024 linked a pull request Aug 11, 2024 that will close this issue
Backmerge: #2213 - Layout for 1-step reactions is broken #2214
Merged
7 tasks
even1024 added a commit that referenced this issue Aug 12, 2024
@even1024
Backmerge: #2213 - Layout for 1-step reactions is broken (#2214)
5eb60ce
@even1024 even1024 linked a pull request Aug 12, 2024 that will close this issue
#2213 - Layout for 1-step reactions is broken #2220
Merged
7 tasks
even1024 added a commit that referenced this issue Aug 12, 2024
@even1024
#2213 - Layout for 1-step reactions is broken (#2220)
407ab4d
This was referenced Aug 15, 2024
Closed
Closed
@AlexeyGirin
Copy link
Collaborator

Fixed.
Smart layout OFF
image

Smart layout ON
image

  • Ketcher Version 2.24.0-rc.2 Build at 2024-08-14; 19:00:14
  • Indigo Toolkit Version 1.23.0-rc.2.0-g6a2a7526a-wasm32-wasm-clang-19.0.0
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)
  • Win10

@ivanmaslow
Copy link
Collaborator

Also, in scope of this issue these two defects were fixed, structures are just centered after layout:

Env details:

  • Ketcher [Version 2.24.0-rc.2] Build at 2024-08-14; 19:00:14
  • Indigo Version 1.23.0-rc.2.0-g6a2a7526a-wasm32-wasm-clang-19.0.0
  • OS: Windows 11 Enterprise
  • Browser: Crhome, Version 127.0.6533.119 (Official Build) (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@even1024 even1024

Labels
None yet
Projects
None yet
Milestone
Indigo-1.23.0-rc.2
3 participants
@even1024 @AlexeyGirin @ivanmaslow