Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ACS style rendering options to customize molecule elements #2246

Closed
AleksandrParamonoff opened this issue Aug 16, 2024 · 2 comments · Fixed by #2434
Closed

Add ACS style rendering options to customize molecule elements #2246

AleksandrParamonoff opened this issue Aug 16, 2024 · 2 comments · Fixed by #2434
Assignees
@AliaksandrDziarkach
Labels
ACS standard phase III SVG/PNG Bucket: Bugs related to SVG/PNG export Team G
Milestone
Indigo-1.25.0-rc.1

Comments

@AleksandrParamonoff
Copy link
Collaborator

AleksandrParamonoff commented Aug 16, 2024 •
edited by AliaksandrDziarkach
Loading

Background
Currently, the ACS style settings are not supported by Indigo rendering module(PNG and SVG output formats).

Requirements
The following parameters should be processed for rendering:
render-bond-spacing (default = 0.18 i.e. bondLength * 0.18)
render-stereo-bond-width
render-stereo-bond-width-unit
render-hash-spacing
render-hash-spacing-unit

Additional context
related issues:
#2175
#2176
@AleksandrParamonoff AleksandrParamonoff added SVG/PNG Bucket: Bugs related to SVG/PNG export phase III Team G ACS standard labels Aug 16, 2024
@AleksandrParamonoff AleksandrParamonoff mentioned this issue Aug 16, 2024
Closed
@AlexanderSavelyev AlexanderSavelyev mentioned this issue Aug 27, 2024
Closed
@AlexeyGirin
Copy link
Collaborator

ACS-StyleGuide.pdf

AliaksandrDziarkach added a commit that referenced this issue Sep 26, 2024
@AliaksandrDziarkach
#2175 - Adjust the rendering of PNG and SVG formats for ACS style
4bded8d 
Also contains changes for #2246. Update code. Add UT.
@AliaksandrDziarkach AliaksandrDziarkach mentioned this issue Sep 26, 2024
Merged
7 tasks
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Sep 26, 2024 that will close this issue
#2175 - Adjust the rendering of PNG and SVG formats for ACS style #2434
Merged
7 tasks
@AlekseiKhariukov AlekseiKhariukov added this to the Indigo-1.25.0-rc.1 milestone Sep 30, 2024
@AnnaKosol
Copy link
Collaborator

Verified

Environment
https://rc.test.lifescience.opensource.epam.com/KetcherDemoSA/index.html
Ketcher Version 2.26.0-rc.1 Build at 2024-10-04; 18:45:04
Indigo Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
MacOs
Chrome 129.0.6668.71 (Official Build) (arm64)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
ACS standard phase III SVG/PNG Bucket: Bugs related to SVG/PNG export Team G
Projects
None yet
Milestone
Indigo-1.25.0-rc.1
Development

Successfully merging a pull request may close this issue.

#2175 - Adjust the rendering of PNG and SVG formats for ACS style epam/Indigo
5 participants
@AliaksandrDziarkach @AlexeyGirin @AnnaKosol @AlekseiKhariukov @AleksandrParamonoff