Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout and Save to RXN/RDF works not correctly when Multi-Tailed Arrow is on canvas without elements near tails or head, If no elements are near multi-tailed arrow, layout action should consider it as empty elements #2424

Open
ivanmaslow opened this issue Sep 24, 2024 · 0 comments
Assignees
Labels
Bug Cascade reactions Export to RXN Bucket: Export to RXN related issues Layout MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: High

Comments

@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Sep 24, 2024

Steps to Reproduce Case 1

  1. Add Multi-Tailed Arrow with 3 tails:
    image
  2. Click on Layout

Actual behavior

  • Arrow appears, Multi-Tailed Arrow is moved:
    image

Expected behavior

  1. Click one more time - multi-tailed arrow disappears, the arrow is moved to the center
    image

Steps to Reproduce Case 2

  1. Add Multi-Tailed Arrow with 3 tails, add benzene rings, leave two tails without elements:
    image
  2. Click on Layout

Actual behavior

  • Arrow appears, Multi-Tailed Arrow is moved:
    image

Expected behavior

  • Multi-Tailed arrow is moved to the center with elements and size of arrow is changed to default for indigo:
    image
  1. Click one more time - multi-tailed arrow disappears, the arrow is moved to the center

Steps to Reproduce Case 3

  1. Add Multi-Tailed Arrow with 3 tails, add elements and single arrow:
    image
  2. Click on Layout

Actual behavior

  • Multi-Tailed Arrow disappear:
    image

Expected behavior

  • Multi-Tailed arrow is moved to the center with elements and size of arrow is changed to default for indigo

Environment details

  • Tested on CI-CD 2237-detect-pathway SA environment
  • Ketcher [Version 2.25.0-rc.2] Build at 2024-09-24; 02:30:35
  • Indigo Version 1.25.0-dev.1.58-ga966745f-wasm32-wasm-clang-12.0.0
  • Windows 11 Enterprise
  • Chrome Version 129.0.6668.59 (Official Build) (64-bit)

Notes

  • Test cases are added to xls for RDF, RXN and Layout and should be automated
  • This fix is affected save to RXN/RDF as well, for example a case with Cascade reaction:
    1. Add a reaction from the KET file:
      1-cascade-branches-ordering.zip
    2. Add an additional tail to any multi-tailed arrow:
      image
    3. Click on save to RDF - there is a 6:4 reaction that's not correct, all elements shouldn't be united:
      image
  • Issue is detected during exploratory testing of Import/Export of Multi-Tailed Arrow in cascade reactions - Import/export multi-tails in KET #2236
@ivanmaslow ivanmaslow added Bug Layout Priority: High Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Sep 24, 2024
@ivanmaslow ivanmaslow added this to the Indigo-1.25.0-rc.1 milestone Sep 24, 2024
@ivanmaslow ivanmaslow changed the title Preview: Layout action works not correctly when Multi-Tailed Arrow is on canvas without elements near tails or head, If no elements are near multi-tailed arrow, layout action should consider it as empty elements Layout action works not correctly when Multi-Tailed Arrow is on canvas without elements near tails or head, If no elements are near multi-tailed arrow, layout action should consider it as empty elements Oct 4, 2024
@ivanmaslow ivanmaslow changed the title Layout action works not correctly when Multi-Tailed Arrow is on canvas without elements near tails or head, If no elements are near multi-tailed arrow, layout action should consider it as empty elements Layout and Save to RXN/RDF works not correctly when Multi-Tailed Arrow is on canvas without elements near tails or head, If no elements are near multi-tailed arrow, layout action should consider it as empty elements Oct 10, 2024
@ivanmaslow ivanmaslow added the Export to RXN Bucket: Export to RXN related issues label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Cascade reactions Export to RXN Bucket: Export to RXN related issues Layout MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: High
Projects
None yet
Development

No branches or pull requests

3 participants