Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub font size is incorrect when save to png (svg) #2446

Closed
AnnaKosol opened this issue Sep 30, 2024 · 2 comments · Fixed by #2572 or #2573
Closed

Sub font size is incorrect when save to png (svg) #2446

AnnaKosol opened this issue Sep 30, 2024 · 2 comments · Fixed by #2572 or #2573
Assignees
@AliaksandrDziarkach
Labels
Bug Priority: High SVG/PNG Bucket: Bugs related to SVG/PNG export Team G
Milestone
Indigo-1.25.0-rc.4

Comments

@AnnaKosol
Copy link
Collaborator

Steps to Reproduce

  1. add chain to the Canvas
Снимок экрана 2024-09-30 в 14 01 35
  1. set 30 pt to the Sub Font size in the Settings
  2. click on the Apply button
  3. save to PNG (svg)

Expected behavior
Снимок экрана 2024-09-30 в 14 41 58

Actual behavior
atoms are displayed without settings
Снимок экрана 2024-09-30 в 14 42 18

Environment details:

Issues found while testing #2175
@AnnaKosol AnnaKosol added Bug Priority: Medium SVG/PNG Bucket: Bugs related to SVG/PNG export labels Sep 30, 2024
@AliaksandrDziarkach AliaksandrDziarkach mentioned this issue Sep 30, 2024
Closed
@AliaksandrDziarkach AliaksandrDziarkach self-assigned this Sep 30, 2024
@AliaksandrDziarkach
Copy link
Collaborator

Looks like indigo render use same font size for all parts of atom label.

@AlexanderSavelyev AlexanderSavelyev added this to the Indigo-1.25.0-rc.2 milestone Oct 7, 2024
@AnnaKosol AnnaKosol changed the title Preview: sub font size is incorrect when save to png (cvg) Sub font size is incorrect when save to png (cvg) Oct 7, 2024
@AlexeyGirin AlexeyGirin changed the title Sub font size is incorrect when save to png (cvg) Sub font size is incorrect when save to png (svg) Oct 23, 2024
AliaksandrDziarkach added a commit that referenced this issue Oct 23, 2024
@AliaksandrDziarkach
#2446 - Sub font size is incorrect when save to png (svg)
8727cd7 
Fix typo. Update UT
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Oct 23, 2024 that will close this issue
#2446 - Sub font size is incorrect when save to png (svg) #2572
Merged
8 tasks
AliaksandrDziarkach added a commit that referenced this issue Oct 23, 2024
@AliaksandrDziarkach
Backmerge: #2446 - Sub font size is incorrect when save to png (svg)
4362813 
Backmerge to master
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Oct 23, 2024 that will close this issue
Backmerge: #2446 - Sub font size is incorrect when save to png (svg) #2573
Merged
4 tasks
AlexanderSavelyev pushed a commit that referenced this issue Oct 23, 2024
@AliaksandrDziarkach
#2446 - Sub font size is incorrect when save to png (svg) (#2572)
7b6a23c
AlexanderSavelyev pushed a commit that referenced this issue Oct 24, 2024
@AliaksandrDziarkach
Backmerge: #2446 - Sub font size is incorrect when save to png (svg) (#…
2af1c72 
…2573)
@AlexeyGirin
Copy link
Collaborator

Verified.
image

  • Ketcher Version 2.26.0-rc.6 Build at 2024-10-25; 09:57:12
  • Indigo Toolkit Version 1.25.0-rc.4.0-g8862ccb7e-wasm32-wasm-clang-19.0.0
  • Chrome Version 130.0.6723.59 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Bug Priority: High SVG/PNG Bucket: Bugs related to SVG/PNG export Team G
Projects
None yet
Milestone
Indigo-1.25.0-rc.4
4 participants
@AlexanderSavelyev @AliaksandrDziarkach @AlexeyGirin @AnnaKosol