Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single reaction with Multi-Tailed arrow is corrupted after loading from RXN if the elements were too close to arrow on save #2485

Closed
ivanmaslow opened this issue Oct 3, 2024 · 2 comments · Fixed by #2570
Assignees
Labels
Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: High

Comments

@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Oct 3, 2024

It's reproduced for Multi-Tailed and Single Arrows.
Steps to Reproduce

  1. Add a reaction with Multi-Tailed Arrow to Canvas, add chemical elements very close to the second tail of the arrow or add it from the KET file below:
    ketcher.zip
    image
  2. Click on Save as..., select RXN V2000/V3000
  3. Copy RXN from the preview and paste to Canvas

Actual Result

  • Reaction is corrupted:
    image

Expected Result

  • 2:1 reaction with single arrow and plus is displayed
    image

Environment details

  • Detected on CI-CD master env
  • Ketcher [Version 2.25.0-rc.2] Build at 2024-10-03; 05:09:39
  • Indigo Version 1.25.0-dev.3.4-g6469f588-wasm32-wasm-clang-12.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 129.0.6668.71 (Official Build) (64-bit)

Notes

@ivanmaslow ivanmaslow added Bug Priority: High Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Oct 3, 2024
@ivanmaslow ivanmaslow changed the title Preview: Issue with loading from RXN single reaction if the elements are too close to arrow Issue with loading from RXN single reaction with Multi-Tailed Arrow if the elements are too close to arrow Oct 4, 2024
@ivanmaslow ivanmaslow changed the title Issue with loading from RXN single reaction with Multi-Tailed Arrow if the elements are too close to arrow Single reaction with Multi-Tailed arrow is corrupted after loading from RXN if the elements were too close to arrow on save Oct 4, 2024
@ivanmaslow
Copy link
Collaborator Author

Pre-tested on aws_ci environment with Ketcher master and Indigo 2407-branch-ordering branches:

  • Ketcher [Version 2.26.0-rc.1] Build at 2024-10-24; 12:25:38;
  • Indigo Version 1.25.0-rc.3.18-gcdee98d4-wasm32-wasm-clang-12.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 130.0.6723.70 (Official Build) (64-bit)

image
Reaction is displayed correctly after loading from RXN:
image

@ivanmaslow
Copy link
Collaborator Author

The fix is successfully verified on RC SA env:

  • Ketcher [Version 2.26.0-rc.6] Build at 2024-10-25; 09:57:12
  • Indigo Version 1.25.0-rc.4.0-g8862ccb7e-wasm32-wasm-clang-19.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 130.0.6723.70 (Official Build) (64-bit)

As mentioned above the issue is fixed and reaction is loaded correctly from RXN or RDF files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: High
Projects
None yet
4 participants